Skip to content

Commit

Permalink
Add comments for translators (#9510)
Browse files Browse the repository at this point in the history
* Add translator comments for "special" strings

* Add translator comments for some "tricky" strings
  • Loading branch information
Wuzzy2 authored Mar 20, 2020
1 parent 5c1b725 commit 625b100
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 0 deletions.
11 changes: 11 additions & 0 deletions builtin/mainmenu/dlg_settings_advanced.lua
Original file line number Diff line number Diff line change
Expand Up @@ -639,12 +639,23 @@ local function create_change_setting_formspec(dialogdata)
-- Flags
formspec = table.concat(fields)
.. "checkbox[0.5," .. height - 0.6 .. ";cb_defaults;"
--[[~ "defaults" is a noise parameter flag.
It describes the default processing options
for noise settings in main menu -> "All Settings". ]]
.. fgettext("defaults") .. ";" -- defaults
.. tostring(flags["defaults"] == true) .. "]" -- to get false if nil
.. "checkbox[5," .. height - 0.6 .. ";cb_eased;"
--[[~ "eased" is a noise parameter flag.
It is used to make the map smoother and
can be enabled in noise settings in
main menu -> "All Settings". ]]
.. fgettext("eased") .. ";" -- eased
.. tostring(flags["eased"] == true) .. "]"
.. "checkbox[5," .. height - 0.15 .. ";cb_absvalue;"
--[[~ "absvalue" is a noise parameter flag.
It is short for "absolute value".
It can be enabled in noise settings in
main menu -> "All Settings". ]]
.. fgettext("absvalue") .. ";" -- absvalue
.. tostring(flags["absvalue"] == true) .. "]"
height = height + 1
Expand Down
1 change: 1 addition & 0 deletions builtin/mainmenu/tab_online.lua
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ local function get_formspec(tabview, name, tabdata)
"text,align=right,padding=0.25;" .. -- clients_max
image_column(fgettext("Creative mode"), "creative") .. ",padding=1;" ..
image_column(fgettext("Damage enabled"), "damage") .. ",padding=0.25;" ..
--~ PvP = Player versus Player
image_column(fgettext("PvP enabled"), "pvp") .. ",padding=0.25;" ..
"color,span=1;" ..
"text,padding=1]" ..
Expand Down
8 changes: 8 additions & 0 deletions src/client/fontengine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@ void FontEngine::readSettings()
m_default_size[FM_Fallback] = m_settings->getU16("fallback_font_size");
m_default_size[FM_Mono] = m_settings->getU16("mono_font_size");

/*~ DO NOT TRANSLATE THIS LITERALLY!
This is a special string. Put either "no" or "yes"
into the translation field (literally).
Choose "yes" if the language requires use of the fallback
font, "no" otherwise.
The fallback font is (normally) required for languages with
non-Latin script, like Chinese.
When in doubt, test your translation. */
m_currentMode = is_yes(gettext("needs_fallback_font")) ?
FM_Fallback : FM_Standard;

Expand Down
1 change: 1 addition & 0 deletions src/client/game.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4184,6 +4184,7 @@ void Game::showPauseMenu()
<< strgettext("- Creative Mode: ") << creative << "\n";
if (!simple_singleplayer_mode) {
const std::string &pvp = g_settings->getBool("enable_pvp") ? on : off;
//~ PvP = Player versus Player
os << strgettext("- PvP: ") << pvp << "\n"
<< strgettext("- Public: ") << announced << "\n";
std::string server_name = g_settings->get("server_name");
Expand Down
3 changes: 3 additions & 0 deletions src/client/keycode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ static const struct table_key table[] = {
DEFINEKEY1(KEY_RETURN, N_("Return"))
DEFINEKEY1(KEY_SHIFT, N_("Shift"))
DEFINEKEY1(KEY_CONTROL, N_("Control"))
//~ Key name, common on Windows keyboards
DEFINEKEY1(KEY_MENU, N_("Menu"))
DEFINEKEY1(KEY_PAUSE, N_("Pause"))
DEFINEKEY1(KEY_CAPITAL, N_("Caps Lock"))
Expand All @@ -121,7 +122,9 @@ static const struct table_key table[] = {
DEFINEKEY1(KEY_UP, N_("Up"))
DEFINEKEY1(KEY_RIGHT, N_("Right"))
DEFINEKEY1(KEY_DOWN, N_("Down"))
//~ Key name
DEFINEKEY1(KEY_SELECT, N_("Select"))
//~ "Print screen" key
DEFINEKEY1(KEY_PRINT, N_("Print"))
DEFINEKEY1(KEY_EXECUT, N_("Execute"))
DEFINEKEY1(KEY_SNAPSHOT, N_("Snapshot"))
Expand Down
2 changes: 2 additions & 0 deletions src/gui/modalMenu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ bool GUIModalMenu::preprocessEvent(const SEvent &event)
return retval;

m_jni_field_name = field_name;
/*~ Imperative, as in "Enter/type in text".
Don't forget the space. */
std::string message = gettext("Enter ");
std::string label = wide_to_utf8(getLabelByID(hovered->getID()));
if (label.empty())
Expand Down
3 changes: 3 additions & 0 deletions src/network/clientpackethandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ void Client::handleCommand_AuthAccept(NetworkPacket* pkt)
<< m_recommended_send_interval<<std::endl;

// Reply to server
/*~ DO NOT TRANSLATE THIS LITERALLY!
This is a special string which needs to contain the translation's
language code (e.g. "de" for German). */
std::string lang = gettext("LANG_CODE");
if (lang == "LANG_CODE")
lang = "";
Expand Down
1 change: 1 addition & 0 deletions util/updatepo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ cd ..
# --package-name
potfile=po/minetest.pot
xgettext --package-name=minetest \
--add-comments='~' \
--sort-by-file \
--add-location=file \
--keyword=N_ \
Expand Down

0 comments on commit 625b100

Please sign in to comment.