Skip to content
Permalink
Browse files

Translations: prevent remote crash with invalid translations

  • Loading branch information...
Ekdohibs committed Aug 25, 2017
1 parent d3f1743 commit 6761e213836e902359c5d0acff277623dc3e1588
Showing with 6 additions and 1 deletion.
  1. +6 −1 src/util/string.cpp
@@ -866,7 +866,12 @@ void translate_string(const std::wstring &s, const std::wstring &textdomain,
// Here we have an argument; get its index and add the translated argument to the output.
int arg_index = toutput[j] - L'1';
++j;
result << args[arg_index];
if (0 <= arg_index && (size_t)arg_index < args.size()) {
result << args[arg_index];
} else {
// This is not allowed: show an error message
errorstream << "Ignoring out-of-bounds argument escape sequence in translation" << std::endl;
}
}
res = result.str();
}

0 comments on commit 6761e21

Please sign in to comment.
You can’t perform that action at this time.