Skip to content
Permalink
Browse files
Noise: Prevent unittest crash caused by division by zero
  • Loading branch information
SmallJoker committed Jul 29, 2017
1 parent e9d7005 commit 765fd9a0bc0bb9f08d12713dc586e7f4c59c421d
Showing 1 changed file with 3 additions and 1 deletion.
@@ -130,7 +130,9 @@ s32 PcgRandom::range(s32 min, s32 max)
if (max < min)
throw PrngException("Invalid range (max < min)");

u32 bound = max - min + 1;
// We have to cast to s64 because otherwise this could overflow,
// and signed overflow is undefined behavior.
u32 bound = (s64)max - (s64)min + 1;
return range(bound) + min;
}

0 comments on commit 765fd9a

Please sign in to comment.