Skip to content
Permalink
Browse files

Set default value for ENABLE_REDIS to 0

  • Loading branch information
sfan5 committed Jan 10, 2015
1 parent 30334b6 commit 8089d89a5129d170e5d36c16c3897f252a85d5c2
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/CMakeLists.txt
@@ -295,7 +295,7 @@ endif(ENABLE_LEVELDB)

set(USE_REDIS 0)

OPTION(ENABLE_REDIS "Enable redis backend" 1)
OPTION(ENABLE_REDIS "Enable redis backend" 0)

if(ENABLE_REDIS)
find_library(REDIS_LIBRARY hiredis)

4 comments on commit 8089d89

@ShadowNinja

This comment has been minimized.

Copy link
Member

@ShadowNinja ShadowNinja replied Jan 10, 2015

The redis block should be in cmake/Modules/FindRedis.cmake.

@sfan5

This comment has been minimized.

Copy link
Member Author

@sfan5 sfan5 replied Jan 10, 2015

Do you want to have a seperate file for each library or what?

@ShadowNinja

This comment has been minimized.

Copy link
Member

@ShadowNinja ShadowNinja replied Jan 10, 2015

@sfan5 Yes, that's how we do it. See the other files in that folder. It reduces the length of the main file and you can use find_package_handle_standard_args for even more code reduction.

@Calinou

This comment has been minimized.

Copy link
Member

@Calinou Calinou replied Jan 11, 2015

Why not enable both LevelDB and Redis if the respective libraries are found? There could be a warning in case these libraries are not found, but Minetest would still compile with support disabled for them.

Please sign in to comment.