Skip to content
Permalink
Browse files

Fix issue #1009 (minetest.get_connected_players() returns non-existin…

…g players)
  • Loading branch information
kwolekr committed Nov 17, 2013
1 parent a55c073 commit 86ef7147b60868f86d38d55a1dcf6271d68427ce
Showing with 17 additions and 1 deletion.
  1. +3 −1 builtin/misc.lua
  2. +11 −0 src/script/lua_api/l_object.cpp
  3. +3 −0 src/script/lua_api/l_object.h
@@ -53,7 +53,9 @@ end)
function minetest.get_connected_players()
local temp_table = {}
for index, value in pairs(player_list) do
table.insert(temp_table, value)
if value:is_player_connected() then
table.insert(temp_table, value)
end
end
return temp_table
end
@@ -621,6 +621,16 @@ int ObjectRef::l_is_player(lua_State *L)
return 1;
}

// is_player_connected(self)
int ObjectRef::l_is_player_connected(lua_State *L)
{
NO_MAP_LOCK_REQUIRED;
ObjectRef *ref = checkobject(L, 1);
Player *player = getplayer(ref);
lua_pushboolean(L, (player != NULL && player->peer_id != 0));
return 1;
}

// get_player_name(self)
int ObjectRef::l_get_player_name(lua_State *L)
{
@@ -1148,6 +1158,7 @@ const luaL_reg ObjectRef::methods[] = {
luamethod(ObjectRef, get_luaentity),
// Player-only
luamethod(ObjectRef, is_player),
luamethod(ObjectRef, is_player_connected),
luamethod(ObjectRef, get_player_name),
luamethod(ObjectRef, get_look_dir),
luamethod(ObjectRef, get_look_pitch),
@@ -158,6 +158,9 @@ class ObjectRef : public ModApiBase {
// is_player(self)
static int l_is_player(lua_State *L);

// is_player_connected(self)
static int l_is_player_connected(lua_State *L);

// get_player_name(self)
static int l_get_player_name(lua_State *L);

0 comments on commit 86ef714

Please sign in to comment.
You can’t perform that action at this time.