Use fixed-width format specifiers in serializeStructToString

minetest · Mar 13, 2014 · 875f1327a47f78d783c3abc7f7acc3977dc286ec · 875f132 · cheapie · Mar 14, 2014
1 parent e4d1970
commit 875f1327a47f78d783c3abc7f7acc3977dc286ec
Unified Split

Showing with 4 additions and 3 deletions.

+4 −3 src/util/serialize.cpp
diff --git a/src/util/serialize.cpp b/src/util/serialize.cpp
@@ -24,6 +24,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "../exceptions.h"
 #include "../irrlichttypes.h"
 
+#include <inttypes.h>  // For PRIxN, cinttypes is C++11-only
 #include <sstream>
 #include <iomanip>
 #include <vector>
@@ -416,19 +417,19 @@ bool serializeStructToString(std::string *outstr,
 				if (width == 16) {
 					bufpos += PADDING(bufpos, u16);
 					nprinted = snprintf(sbuf + pos, sbuflen,
-								is_unsigned ? "%u, " : "%d, ",
+								is_unsigned ? "%" PRIu16 ", " : "%" PRIi16 ", ",
 								*((u16 *)bufpos));
 					bufpos += sizeof(u16);
 				} else if (width == 32) {
 					bufpos += PADDING(bufpos, u32);
 					nprinted = snprintf(sbuf + pos, sbuflen,
-								is_unsigned ? "%u, " : "%d, ",
+								is_unsigned ? "%" PRIu32 ", " : "%" PRIi32 ", ",
 								*((u32 *)bufpos));
 					bufpos += sizeof(u32);
 				} else if (width == 64) {
 					bufpos += PADDING(bufpos, u64);
 					nprinted = snprintf(sbuf + pos, sbuflen,
-								is_unsigned ? "%llu, " : "%lli, ",
+								is_unsigned ? "%" PRIu64 ", " : "%" PRIi64 ", ",
 								*((u64 *)bufpos));
 					bufpos += sizeof(u64);
 				}