Forbid object:attach(obj, ...) (#9762)

Fixes #9761
minetest · Apr 27, 2020 · 91c4f7f0ea0b653d15bfabc05f5474f8fa1a8806 · 91c4f7f
1 parent be71e70
commit 91c4f7f0ea0b653d15bfabc05f5474f8fa1a8806
Unified Split

Showing with 5 additions and 0 deletions.

+5 −0 src/script/lua_api/l_object.cpp
diff --git a/src/script/lua_api/l_object.cpp b/src/script/lua_api/l_object.cpp
@@ -674,8 +674,13 @@ int ObjectRef::l_set_attach(lua_State *L)
 	ServerActiveObject *parent = getobject(parent_ref);
 	if (co == NULL)
 		return 0;
+
 	if (parent == NULL)
 		return 0;
+
+	if (co == parent)
+		throw LuaError("ObjectRef::set_attach: attaching object to itself is not allowed.");
+
 	// Do it
 	int parent_id = 0;
 	std::string bone;