Skip to content
Permalink
Browse files

Treegen: Improve use of signed vs. unsigned integers

To fix GCC 6.1.1 compilation warning:
'assuming signed overflow does not occur when assuming
that (X - c) > X is always false'
  • Loading branch information
paramat committed Jul 10, 2016
1 parent 7eeb735 commit 91f68e7d11e89dbc73ec259eb057de51099dfe8c
Showing with 3 additions and 3 deletions.
  1. +3 −3 src/treegen.cpp
@@ -770,9 +770,9 @@ void make_pine_tree(MMVManip &vmanip, v3s16 p0, INodeDefManager *ndef, s32 seed)
MapNode snownode(c_snow);

PseudoRandom pr(seed);
s16 trunk_h = pr.range(9, 13);
u16 trunk_h = pr.range(9, 13);
v3s16 p1 = p0;
for (s16 ii = 0; ii < trunk_h; ii++) {
for (u16 ii = 0; ii < trunk_h; ii++) {
if (vmanip.m_area.contains(p1)) {
u32 vi = vmanip.m_area.index(p1);
vmanip.m_data[vi] = treenode;
@@ -790,7 +790,7 @@ void make_pine_tree(MMVManip &vmanip, v3s16 p0, INodeDefManager *ndef, s32 seed)
leaves_d[i] = 0;

// Upper branches
s16 dev = 3;
u16 dev = 3;
for (s16 yy = -1; yy <= 1; yy++) {
for (s16 zz = -dev; zz <= dev; zz++) {
u32 i = leaves_a.index(v3s16(-dev, yy, zz));

0 comments on commit 91f68e7

Please sign in to comment.
You can’t perform that action at this time.