Skip to content
Permalink
Browse files

Optimize string handling in path search (#8098)

Use "append" method to construct the various game paths
instead of wasteful string concatenation. Additionally, use a
temporary to extract and reuse a result of a few common
subexpressions to further reduce the overhead.
  • Loading branch information
osjc authored and nerzhul committed Mar 7, 2019
1 parent 007c844 commit bb35d062255ed74f6e1ebe0f7c4714054803b248
Showing with 12 additions and 8 deletions.
  1. +12 −8 src/content/subgames.cpp
@@ -67,15 +67,19 @@ SubgameSpec findSubgame(const std::string &id)
std::vector<GameFindPath> find_paths;
while (!search_paths.at_end()) {
std::string path = search_paths.next(PATH_DELIM);
find_paths.emplace_back(path + DIR_DELIM + id, false);
find_paths.emplace_back(path + DIR_DELIM + id + "_game", false);
path.append(DIR_DELIM).append(id);
find_paths.emplace_back(path, false);
path.append("_game");
find_paths.emplace_back(path, false);
}
find_paths.emplace_back(
user + DIR_DELIM + "games" + DIR_DELIM + id + "_game", true);
find_paths.emplace_back(user + DIR_DELIM + "games" + DIR_DELIM + id, true);
find_paths.emplace_back(
share + DIR_DELIM + "games" + DIR_DELIM + id + "_game", false);
find_paths.emplace_back(share + DIR_DELIM + "games" + DIR_DELIM + id, false);

std::string game_base = DIR_DELIM;
game_base = game_base.append("games").append(DIR_DELIM).append(id);
std::string game_suffixed = game_base + "_game";
find_paths.emplace_back(user + game_suffixed, true);
find_paths.emplace_back(user + game_base, true);
find_paths.emplace_back(share + game_suffixed, false);
find_paths.emplace_back(share + game_base, false);

// Find game directory
std::string game_path;

0 comments on commit bb35d06

Please sign in to comment.