Skip to content

Commit

Permalink
Unify OpenGL ES support
Browse files Browse the repository at this point in the history
  • Loading branch information
sfan5 committed Aug 4, 2019
1 parent 526a9e4 commit ca363d3
Show file tree
Hide file tree
Showing 8 changed files with 39 additions and 21 deletions.
1 change: 1 addition & 0 deletions build/android/jni/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ endif

LOCAL_CFLAGS := -D_IRR_ANDROID_PLATFORM_ \
-DHAVE_TOUCHSCREENGUI \
-DENABLE_GLES=1 \
-DUSE_CURL=1 \
-DUSE_SOUND=1 \
-DUSE_FREETYPE=1 \
Expand Down
7 changes: 6 additions & 1 deletion src/client/renderingengine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,

#endif

#ifdef __ANDROID__
#if ENABLE_GLES
#include "filesys.h"
#endif

Expand Down Expand Up @@ -131,6 +131,11 @@ RenderingEngine::RenderingEngine(IEventReceiver *receiver)
params.OGLES2ShaderPath = std::string(porting::path_user + DIR_DELIM + "media" +
DIR_DELIM + "Shaders" + DIR_DELIM).c_str();
// clang-format on
#elif ENABLE_GLES
// there is no standardized path for these on desktop
std::string rel_path = std::string("client") + DIR_DELIM
+ "shaders" + DIR_DELIM + "Irrlicht";
params.OGLES2ShaderPath = (porting::path_share + DIR_DELIM + rel_path + DIR_DELIM).c_str();
#endif

m_device = createDeviceEx(params);
Expand Down
5 changes: 3 additions & 2 deletions src/client/sky.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include "client/renderingengine.h"
#include "settings.h"
#include "camera.h" // CameraModes
#include "config.h"


Sky::Sky(s32 id, ITextureSource *tsrc):
Expand All @@ -44,7 +45,7 @@ Sky::Sky(s32 id, ITextureSource *tsrc):

video::SMaterial mat;
mat.Lighting = false;
#ifdef __ANDROID__
#if ENABLE_GLES
mat.ZBuffer = video::ECFN_DISABLED;
#else
mat.ZBuffer = video::ECFN_NEVER;
Expand Down Expand Up @@ -273,7 +274,7 @@ void Sky::render()
// Stars are only drawn when brighter than skycolor
if (starcolor.getBlue() < m_skycolor.getBlue())
break;
#ifdef __ANDROID__
#if ENABLE_GLES
u16 indices[SKY_STAR_COUNT * 3];
video::S3DVertex vertices[SKY_STAR_COUNT * 3];
for (u32 i = 0; i < SKY_STAR_COUNT; i++) {
Expand Down
18 changes: 11 additions & 7 deletions src/client/tile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,

#include <algorithm>
#include <ICameraSceneNode.h>
#include <IrrCompileConfig.h>
#include "util/string.h"
#include "util/container.h"
#include "util/thread.h"
Expand All @@ -34,8 +35,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include "renderingengine.h"


#ifdef __ANDROID__
#if ENABLE_GLES
#ifdef _IRR_COMPILE_WITH_OGLES1_
#include <GLES/gl.h>
#else
#include <GLES2/gl2.h>
#endif
#endif

/*
Expand Down Expand Up @@ -595,7 +600,7 @@ u32 TextureSource::generateTexture(const std::string &name)
video::ITexture *tex = NULL;

if (img != NULL) {
#ifdef __ANDROID__
#if ENABLE_GLES
img = Align2Npot2(img, driver);
#endif
// Create texture from resulting image
Expand Down Expand Up @@ -752,7 +757,7 @@ void TextureSource::rebuildImagesAndTextures()
// Recreate textures
for (TextureInfo &ti : m_textureinfo_cache) {
video::IImage *img = generateImage(ti.name);
#ifdef __ANDROID__
#if ENABLE_GLES
img = Align2Npot2(img, driver);
#endif
// Create texture from resulting image
Expand Down Expand Up @@ -989,16 +994,15 @@ video::IImage* TextureSource::generateImage(const std::string &name)
return baseimg;
}

#ifdef __ANDROID__
#include <GLES/gl.h>
#if ENABLE_GLES
/**
* Check and align image to npot2 if required by hardware
* @param image image to check for npot2 alignment
* @param driver driver to use for image operations
* @return image or copy of image aligned to npot2
*/

inline u16 get_GL_major_version()
static inline u16 get_GL_major_version()
{
const GLubyte *gl_version = glGetString(GL_VERSION);
return (u16) (gl_version[0] - '0');
Expand Down Expand Up @@ -1078,7 +1082,7 @@ bool TextureSource::generateImagePart(std::string part_of_name,
// Stuff starting with [ are special commands
if (part_of_name.empty() || part_of_name[0] != '[') {
video::IImage *image = m_sourcecache.getOrLoad(part_of_name);
#ifdef __ANDROID__
#if ENABLE_GLES
image = Align2Npot2(image, driver);
#endif
if (image == NULL) {
Expand Down
5 changes: 3 additions & 2 deletions src/client/tile.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <SMaterial.h>
#include <memory>
#include "util/numeric.h"
#include "config.h"

#if __ANDROID__
#if ENABLE_GLES
#include <IVideoDriver.h>
#endif

Expand Down Expand Up @@ -133,7 +134,7 @@ class IWritableTextureSource : public ITextureSource

IWritableTextureSource *createTextureSource();

#ifdef __ANDROID__
#if ENABLE_GLES
video::IImage * Align2Npot2(video::IImage * image, irr::video::IVideoDriver* driver);
#endif

Expand Down
15 changes: 13 additions & 2 deletions src/defaultsettings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/

#include <IrrCompileConfig.h>
#include "settings.h"
#include "porting.h"
#include "filesys.h"
Expand Down Expand Up @@ -182,7 +183,15 @@ void set_default_settings(Settings *settings)
settings->setDefault("lighting_boost_spread", "0.2");
settings->setDefault("texture_path", "");
settings->setDefault("shader_path", "");
#if ENABLE_GLES
#ifdef _IRR_COMPILE_WITH_OGLES1_
settings->setDefault("video_driver", "ogles1");
#else
settings->setDefault("video_driver", "ogles2");
#endif
#else
settings->setDefault("video_driver", "opengl");
#endif
settings->setDefault("cinematic", "false");
settings->setDefault("camera_smoothing", "0");
settings->setDefault("cinematic_camera_smoothing", "0.7");
Expand Down Expand Up @@ -217,7 +226,11 @@ void set_default_settings(Settings *settings)
settings->setDefault("texture_clean_transparent", "false");
settings->setDefault("texture_min_size", "64");
settings->setDefault("ambient_occlusion_gamma", "2.2");
#if ENABLE_GLES
settings->setDefault("enable_shaders", "false");
#else
settings->setDefault("enable_shaders", "true");
#endif
settings->setDefault("enable_particles", "true");
settings->setDefault("arm_inertia", "true");

Expand Down Expand Up @@ -429,9 +442,7 @@ void set_default_settings(Settings *settings)
#ifdef __ANDROID__
settings->setDefault("screen_w", "0");
settings->setDefault("screen_h", "0");
settings->setDefault("enable_shaders", "false");
settings->setDefault("fullscreen", "true");
settings->setDefault("video_driver", "ogles1");
settings->setDefault("touchtarget", "true");
settings->setDefault("TMPFolder", porting::getDataPath("tmp" DIR_DELIM));
settings->setDefault("touchscreen_threshold","20");
Expand Down
5 changes: 2 additions & 3 deletions src/gui/guiEngine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include "client/guiscalingfilter.h"
#include "irrlicht_changes/static_text.h"

#ifdef __ANDROID__
#if ENABLE_GLES
#include "client/tile.h"
#include <GLES/gl.h>
#endif


Expand Down Expand Up @@ -78,7 +77,7 @@ video::ITexture *MenuTextureSource::getTexture(const std::string &name, u32 *id)

m_to_delete.insert(name);

#ifdef __ANDROID__
#if ENABLE_GLES
video::ITexture *retval = m_driver->findTexture(name.c_str());
if (retval)
return retval;
Expand Down
4 changes: 0 additions & 4 deletions src/itemdef.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <map>
#include <set>

#ifdef __ANDROID__
#include <GLES/gl.h>
#endif

/*
ItemDefinition
*/
Expand Down

0 comments on commit ca363d3

Please sign in to comment.