Permalink
4 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Fix warning reported by clang (possible bug in Settings lua api)
- Loading branch information
This comment has been minimized.
I don't think that's it unfortunately, since
checkPath
unconditionally sets it to false (if it's passed) before doing anything just to be safe.This comment has been minimized.
This doesn't fix #4943 for the case where mod security is enabled, it is only supposed to fix the case where mod security is disabled,
CHECK_SECURE_PATH_POSSIBLE_WRITE
does nothing andwrite_allowed
is used uninitialized.Besides, I have actually verified that this fixes the bug with mod security disabled.
This comment has been minimized.
@ShadowNinja From looking at the definition of
CHECK_SECURE_PATH_POSSIBLE_WRITE
it should be obvious that this change is needed.This comment has been minimized.
@sfan5: Oh, you're right. This must have been the cause of #4943, mod security was off.