Skip to content

Commit

Permalink
Fix FTBFS on GNU/Hurd platform
Browse files Browse the repository at this point in the history
Minetest fails to build on GNU/Hurd due to a name clash with OSX/Apple,
both are defining the __MACH__ keyword. This commit fixes the issue.
  • Loading branch information
apoleon authored and Zeno- committed Feb 11, 2015
1 parent caf8d2a commit cfca5f9
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/cguittfont/irrUString.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
#define __BYTE_ORDER 0
#define __LITTLE_ENDIAN 0
#define __BIG_ENDIAN 1
#elif __MACH__
#elif defined(__MACH__) && defined(__APPLE__)
#include <machine/endian.h>
#elif defined(__FreeBSD__)
#include <sys/endian.h>
Expand Down
4 changes: 2 additions & 2 deletions src/jthread/jevent.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

#ifdef _WIN32
#include <windows.h>
#elif __MACH__
#elif defined(__MACH__) && defined(__APPLE__)
#include <mach/mach.h>
#include <mach/task.h>
#include <mach/semaphore.h>
Expand All @@ -43,7 +43,7 @@
class Event {
#ifdef _WIN32
HANDLE hEvent;
#elif __MACH__
#elif defined(__MACH__) && defined(__APPLE__)
semaphore_t sem;
#else
sem_t sem;
Expand Down
4 changes: 2 additions & 2 deletions src/jthread/jsemaphore.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <windows.h>
#include <assert.h>
#define MAX_SEMAPHORE_COUNT 1024
#elif __MACH__
#elif defined(__MACH__) && defined(__APPLE__)
#include <pthread.h>
#include <mach/mach.h>
#include <mach/task.h>
Expand Down Expand Up @@ -52,7 +52,7 @@ class JSemaphore {
private:
#if defined(WIN32)
HANDLE m_hSemaphore;
#elif __MACH__
#elif defined(__MACH__) && defined(__APPLE__)
semaphore_t m_semaphore;
int semcount;
#else
Expand Down
2 changes: 1 addition & 1 deletion src/jthread/pthread/jevent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

#define UNUSED(expr) do { (void)(expr); } while (0)

#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
#undef sem_t
#define sem_t semaphore_t
#undef sem_init
Expand Down
20 changes: 10 additions & 10 deletions src/jthread/pthread/jsemaphore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <errno.h>
#include <sys/time.h>
#include "jthread/jsemaphore.h"
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
#include <unistd.h>
#endif

#define UNUSED(expr) do { (void)(expr); } while (0)

#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
#undef sem_t
#undef sem_init
#undef sem_wait
Expand All @@ -44,7 +44,7 @@ JSemaphore::JSemaphore() {
int sem_init_retval = sem_init(&m_semaphore,0,0);
assert(sem_init_retval == 0);
UNUSED(sem_init_retval);
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
semcount = 0;
#endif
}
Expand Down Expand Up @@ -73,7 +73,7 @@ void JSemaphore::Post() {
int sem_post_retval = sem_post(&m_semaphore);
assert(sem_post_retval == 0);
UNUSED(sem_post_retval);
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
pthread_mutex_lock(&semcount_mutex);
semcount++;
pthread_mutex_unlock(&semcount_mutex);
Expand All @@ -84,15 +84,15 @@ void JSemaphore::Wait() {
int sem_wait_retval = sem_wait(&m_semaphore);
assert(sem_wait_retval == 0);
UNUSED(sem_wait_retval);
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
pthread_mutex_lock(&semcount_mutex);
semcount--;
pthread_mutex_unlock(&semcount_mutex);
#endif
}

bool JSemaphore::Wait(unsigned int time_ms) {
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
mach_timespec_t waittime;
waittime.tv_sec = time_ms / 1000;
waittime.tv_nsec = 1000000 * (time_ms % 1000);
Expand All @@ -106,14 +106,14 @@ bool JSemaphore::Wait(unsigned int time_ms) {
return false;
}

#ifndef __MACH__
#if !(defined(__MACH__) && defined(__APPLE__))
waittime.tv_nsec = ((time_ms % 1000) * 1000 * 1000) + (now.tv_usec * 1000);
waittime.tv_sec = (time_ms / 1000) + (waittime.tv_nsec / (1000*1000*1000)) + now.tv_sec;
waittime.tv_nsec %= 1000*1000*1000;
#endif

errno = 0;
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
int sem_wait_retval = semaphore_timedwait(m_semaphore, waittime);
if (sem_wait_retval == KERN_OPERATION_TIMED_OUT) {
errno = ETIMEDOUT;
Expand All @@ -128,7 +128,7 @@ bool JSemaphore::Wait(unsigned int time_ms) {

if (sem_wait_retval == 0)
{
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
pthread_mutex_lock(&semcount_mutex);
semcount--;
pthread_mutex_unlock(&semcount_mutex);
Expand All @@ -144,7 +144,7 @@ bool JSemaphore::Wait(unsigned int time_ms) {

int JSemaphore::GetValue() {
int retval = 0;
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
pthread_mutex_lock(&semcount_mutex);
retval = semcount;
pthread_mutex_unlock(&semcount_mutex);
Expand Down
8 changes: 4 additions & 4 deletions src/porting.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <unistd.h>
#include <stdint.h> //for uintptr_t

#if (defined(linux) || defined(__linux)) && !defined(_GNU_SOURCE)
#if (defined(linux) || defined(__linux) || defined(__GNU__)) && !defined(_GNU_SOURCE)
#define _GNU_SOURCE
#endif

Expand Down Expand Up @@ -228,7 +228,7 @@ void initIrrlicht(irr::IrrlichtDevice * );
#else // Posix
#include <sys/time.h>
#include <time.h>
#ifdef __MACH__
#if defined(__MACH__) && defined(__APPLE__)
#include <mach/clock.h>
#include <mach/mach.h>
#endif
Expand Down Expand Up @@ -258,7 +258,7 @@ void initIrrlicht(irr::IrrlichtDevice * );
{
struct timespec ts;
// from http://stackoverflow.com/questions/5167269/clock-gettime-alternative-in-mac-os-x
#ifdef __MACH__ // OS X does not have clock_gettime, use clock_get_time
#if defined(__MACH__) && defined(__APPLE__) // OS X does not have clock_gettime, use clock_get_time
clock_serv_t cclock;
mach_timespec_t mts;
host_get_clock_service(mach_host_self(), CALENDAR_CLOCK, &cclock);
Expand Down Expand Up @@ -358,7 +358,7 @@ inline u32 getDeltaMs(u32 old_time_ms, u32 new_time_ms)
inline void setThreadName(const char *name) {
pthread_setname_np(name);
}
#elif defined(_WIN32)
#elif defined(_WIN32) || defined(__GNU__)
inline void setThreadName(const char* name) {}
#else
#warning "Unrecognized platform, thread names will not be available."
Expand Down

0 comments on commit cfca5f9

Please sign in to comment.