Skip to content
Permalink
Browse files

Deny empty username early in the protocol

Thanks to @UltimateNate for pointing this out :)
  • Loading branch information
est31 committed May 22, 2015
1 parent 9facb40 commit e13d2bafc6d0a4fb0d42cf9c229012f4a4f17131
Showing with 5 additions and 3 deletions.
  1. +5 −3 src/network/serverpackethandler.cpp
@@ -164,9 +164,11 @@ void Server::handleCommand_Init(NetworkPacket* pkt)
*/
const char* playername = playerName.c_str();

if (playerName.size() > PLAYERNAME_SIZE) {
actionstream << "Server: Player with an too long name "
<< "tried to connect from " << addr_s << std::endl;
size_t pns = playerName.size();
if (pns == 0 || pns > PLAYERNAME_SIZE) {
actionstream << "Server: Player with "
<< ((pns > PLAYERNAME_SIZE) ? "a too long" : "an empty")
<< " name tried to connect from " << addr_s << std::endl;
DenyAccess(pkt->getPeerId(), SERVER_ACCESSDENIED_WRONG_NAME);
return;
}

1 comment on commit e13d2ba

@nerzhul

This comment has been minimized.

Copy link
Member

@nerzhul nerzhul commented on e13d2ba May 23, 2015

👍

Please sign in to comment.