Skip to content
Permalink
Browse files

Reset block send timer when invoking setBlock(s)NotSent()

As stated in this forum thread [1], I noticed that there is a
2 second interval in which inventory changes are shown on the
client. @yyt16384 found the source of these 2 seconds:
m_nothing_to_send_pause_timer is set to 2.0 every time there
are no changes to make, but this timer is not reset when
SetBlockNotSent or setBlocksNotSent are invoked. So in worst
case, the changed block will be sent over 2 seconds too late.

With this change, changed inventories are updated almost
immediately, but it causes additional connection load.
  • Loading branch information...
orwell96 authored and est31 committed Feb 1, 2016
1 parent a26970c commit e17fbb31d6db3e6d2d9b68f5793ad8b2146f7bcc
Showing with 2 additions and 0 deletions.
  1. +2 −0 src/clientiface.cpp
@@ -391,6 +391,7 @@ void RemoteClient::SentBlock(v3s16 p)
void RemoteClient::SetBlockNotSent(v3s16 p)
{
m_nearest_unsent_d = 0;
m_nothing_to_send_pause_timer = 0;

if(m_blocks_sending.find(p) != m_blocks_sending.end())
m_blocks_sending.erase(p);
@@ -401,6 +402,7 @@ void RemoteClient::SetBlockNotSent(v3s16 p)
void RemoteClient::SetBlocksNotSent(std::map<v3s16, MapBlock*> &blocks)
{
m_nearest_unsent_d = 0;
m_nothing_to_send_pause_timer = 0;

for(std::map<v3s16, MapBlock*>::iterator
i = blocks.begin();

0 comments on commit e17fbb3

Please sign in to comment.
You can’t perform that action at this time.