Skip to content
Permalink
Browse files

Check for valid base64 before decoding (#9904)

  • Loading branch information
Lejo1 authored and SmallJoker committed May 22, 2020
1 parent 7ab0c06 commit e79bc40c0a5312baf4e8c3e33048d50b41b4a2ff
Showing with 7 additions and 3 deletions.
  1. +1 −1 doc/lua_api.txt
  2. +6 −2 src/script/lua_api/l_util.cpp
@@ -5449,7 +5449,7 @@ Misc.
* Example: `minetest.rgba(10, 20, 30, 40)`, returns `"#0A141E28"`
* `minetest.encode_base64(string)`: returns string encoded in base64
* Encodes a string in base64.
* `minetest.decode_base64(string)`: returns string
* `minetest.decode_base64(string)`: returns string or nil for invalid base64
* Decodes a string encoded in base64.
* `minetest.is_protected(pos, name)`: returns boolean
* Returning `true` restricts the player `name` from modifying (i.e. digging,
@@ -318,9 +318,13 @@ int ModApiUtil::l_decode_base64(lua_State *L)
NO_MAP_LOCK_REQUIRED;

size_t size;
const char *data = luaL_checklstring(L, 1, &size);
const char *d = luaL_checklstring(L, 1, &size);
const std::string data = std::string(d, size);

if (!base64_is_valid(data))
return 0;

std::string out = base64_decode(std::string(data, size));
std::string out = base64_decode(data);

lua_pushlstring(L, out.data(), out.size());
return 1;

0 comments on commit e79bc40

Please sign in to comment.
You can’t perform that action at this time.