Skip to content

Commit

Permalink
Pointed thing to face pos: Fix crash if opening door with slab or stair
Browse files Browse the repository at this point in the history
Avoids crash caused when 'pointed thing -under' and '-above' are not
face-neighbours, for example in the case of pointing to the top half
of a door.
  • Loading branch information
MarkuBu authored and paramat committed Apr 19, 2017
1 parent 858c722 commit efd509f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions builtin/common/misc_helpers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -706,13 +706,14 @@ function core.pointed_thing_to_face_pos(placer, pointed_thing)
local oc = {}

for c, v in pairs(pos_off) do
if v == 0 then
if nc or v == 0 then
oc[#oc + 1] = c
else
offset = v
nc = c
end
end

local fine_pos = {[nc] = node_pos[nc] + offset}
camera_pos.y = camera_pos.y + 1.625 + eye_offset_first.y / 10
local f = (node_pos[nc] + offset - camera_pos[nc]) / look_dir[nc]
Expand All @@ -722,4 +723,3 @@ function core.pointed_thing_to_face_pos(placer, pointed_thing)
end
return fine_pos
end

0 comments on commit efd509f

Please sign in to comment.