New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOV mouse sensitivity setting #12483
Conversation
i just noticed i left in another change that modifies the main mouse sensitivity bounds. |
How is that disorienting? I've been playing FPS arenas for years and Minetest without the FOV sensitivity adjustments for at least another year (it's relatively a recent change) and, not gonna lie, it was just horrible. The way the mouse was sliding, not allowing the player any control, just.. ouch. What would be the usecase (quoting #11007 (review))? |
some gamemodes change fov to very large values and could change them with little warning, this means that any movement someone was about to do becomes the wrong distance after the fov change. the kind of fov adjustment done here only really works for lowering fov (shooters and such with scopes), and is quite useful there, since otherwise the mouse sensitivity is far too high, and making large turns is unnecessary with a scope. i use a very high fov in normal gameplay, this means that even a 5 degree increase makes movement extremely difficult to control, it feels like the sensitivity suddenly doubled and i overshoot every rotation. there are plenty of games that i just can't play whatsoever at the current settings. plenty of shooter games have an ads sensitivity setting just for aiming down scopes too, i doubt it's just me that would want it. note that there's also still values other than just on or off, someone might want slightly higher or lower sensitivity down scopes to match their playstyle (for example if they do shorter or longer range combat while scoped, flick/track/wait, etc) |
Sounds useful to me but it definitely needs a better description if not better name, but I don't have a suggestion for that. |
after thinking it over "ADS Mouse Sensitivity" is probably the best name since it's recognizable and people can figure out what it does otherwise by looking it up, even though it isn't technically the most accurate. maybe the description of it could take a disclaimer that it affects all zooming in and out. if a name gets approved i'll resolve the conflict and make the necessary changes |
If I didn't know what this was called in other programs, I'd say something like "Mouse sensitivity: FOV correction strength". But naming it the same as other games makes sense |
i'll leave the master branch to the last point i tested it at, and the quick-untested-merge branch just for resolving simple merge conflicts, i don't want to go far out of my way to maintain this for months just to see if some progress gets made. not to be rude but i'm not sure why this hasn't already been reviewed or merged since as far as i can tell any issues have been resolved quite a while ago |
@SArpnt rebase needed, I'm sorry |
i get the feeling that if i do that, a few months later i'm going to be told this needs another rebase. |
because code on master has been changed and because if we rebased all the PRs that actually need a rebase, we'd end up with even less time than we currently have (we're all volunteers). This also answers to why nobody has checked your PR yet: we're not evil, we're just few :( I could put it into the 5.7 milestone but it's not really my call, I'm sorry. What I can do is remind core devs to review it; just, I need the rebase first |
i changed the head branch of this pull request before when i did the quick-untested-merge branch, but now i can't find any way to change it again or any evidence that it was even possible? |
this adds a setting called FOV mouse sensitivity that adjusts how the mouse sensitivity behaves to fov changes
currently there's an system in place to try and keep screen movement distance equal with any fov, but this is more disorienting to some players than keeping the same amount of rotation (for example me)
at 1.0, the behavior is unchanged, at 0.0, it keeps the same rotations
a more common name for this would be ADS sensitivity (aim down sights) but this implies a shooter game, so i didn't go for this name.
To do
This PR is Ready for Review.
How to test
for checking whether mouse sensitivity here increases or decreases, measure the angles, for example by checking the mouse distance for a 360 rotation