Add setting to customise stack max

[rubenwardy]

eg:

default_stack_max = 34

in minetest.conf.

To add this to a subgame:

You should add the line to minetest.conf in your game's directory.
However, sometimes you may not want players to be able to override it.
To stop this, add the following lines before any items are defined:

minetest.nodedef_default.stack_max      = 123
minetest.craftitemdef_default.stack_max = 123

[rubenwardy]

Stacks with 3200 items on them look okay, according to Megaf.

[SmallJoker]

👍 🐈

[PilzAdam]

This shouldn't be done by a user setting. Some games may not want users to control it.

[rubenwardy]

minetest.nodedef_default.stack_max = 123

Only affects items registered after this statement. Remember craftdef_default and others.

[Calinou]

I would like this, so that I can change Carbone's stack limit to 100 as it more dividers than 99.

[Zeno-]

👍

[Megaf]

👍 🐶

[Amaz1]

👍

[celeron55]

minetest.nodedef_default.stack_max and minetest.craftitemdef_default.stack_max are not documented anywhere. Are those an official API?

[Zeno-]

Yes, the API docs need to be updated if this is to be merged

[rubenwardy]

They're not an official API, they're just objects in builtin which can be modified by mods.

[MirceaKitsune]

I support this. As a default that is, for items which don't specify their own stack max. Each item should be able to define its own within the node definition... I assume this is already possible?

[rubenwardy]

Yes. Items will still be able to use stack_max in their definition. If they don't use stack_max in their definition, then this setting will be used, or 99 if the setting is not set.

[4aiman]

Have read all of it and still didn't get, can I or cannot prevent players from making their inventory bigger w/o asking a server to?

Example:
Magichet shrinks the inventory of a player if he/she has reincarnated w/o using a reincarnator.
If this is to be merged, then would players be able to redefine stack_max locally in order to compensate the lack of free slots to some degree?

So, I'm officially the first one who DOES care for stack_max value be equal amongst magichet players.

[p5yk0g3n3s1s]

👍 Definitely should be added.

[celeron55]

4aiman: It's a server-side setting.

[4aiman]

I hadn't looked at the commit itself - too busy with translation :)
Thanks for clarifying this, celeron55!

👍 from me then :)

[C1ffisme]

👍

[TheShadowZone12]

👍

[rubenwardy]

I will rebase soon.

[C1ffisme]

@rubenwardy BTW what is rebasing? I'm new to github.

[rubenwardy]

This code is a few months old, and since then the Minetest code has changed. Rebasing, in this context, is updating my code to work with the latest Minetest code.

[C1ffisme]

Ah. OK.

[rubenwardy]

Rebased.

[nerzhul]

just a question before i give you my +1, what happens if i reduce the max number and have greater stacks ?

[rubenwardy]

You don't lose any items. They keep in the too large stacks until you break
the stack up by taking items off. (For example if the new stack Max is 50,
you will still have above 50 stacks in the inventory, but you can't add to
them, only take off of them of move them.)

For an example, try /giveme stone 200 in current upstream master.
On 16 Feb 2015 15:03, "nerzhul" notifications@github.com wrote:

just a question before i give you my +1, what happens if i reduce the max
number and have greater stacks ?

—
Reply to this email directly or view it on GitHub
#1843 (comment).

[nerzhul]

Ok then you have my +1

[PilzAdam]

I don't like that setting this in a mod only affects future registered nodes. If a mod wants to change stack_max, then it would need to go through all already registered nodes (from the game) and call override_item on them, which is quite ugly.

[rubenwardy]

In the current upstream you'd need to do exactly the same thing. This pull request is aimed towards end-users and subgames. Mods can use the method that they've used all along.

[ShadowNinja]

@PilzAdam That could be fixed by using metatables, if they aren't used already. IIRC kaeza wrote a patch for that...

[rubenwardy]

Closing as it doesn't look like it's going to be merged

[benrob0329]

Why didn't this get merged? It had an overwhelming amount of 👍s !

[benrob0329]

Oh, nvm.