Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the distribution's system Irrlicht library #2163

Closed
apoleon opened this issue Jan 20, 2015 · 2 comments
Closed

Using the distribution's system Irrlicht library #2163

apoleon opened this issue Jan 20, 2015 · 2 comments
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors

Comments

@apoleon
Copy link
Contributor

apoleon commented Jan 20, 2015

In Debian the attached patch was applied to achieve the following:

https://gist.github.com/apoleon/197065708305dd696376

Distributions like Debian, Ubuntu, Fedora or Gentoo build against a shared version of the Irrlicht engine. But FindIrrlicht.cmake only looks for a static build. I'm not 100% sure how to properly fix this issue for all use cases but it would be great if we could find a way to drop this patch somehow. In the meantime the FIND_LIBRARY function looks for libIrrlicht.so.

@ShadowNinja ShadowNinja added @ Build CMake, build scripts, official builds, compiler and linker errors enhancement labels Jan 20, 2015
@sofar
Copy link
Member

sofar commented Jan 31, 2015

make sharedlib creates the shared irrlicht .so files. These should be easy to pick up and use instead of a static library...

@apoleon
Copy link
Contributor Author

apoleon commented Jan 31, 2015

On Fri, 30. Jan 18:54 Auke Kok notifications@github.com wrote:

make sharedlib creates the shared irrlicht .so files. These should be easy
to pick up and use instead of a static library...

You probably misunderstood this bug report. Linux distributions build
minetest with a separate (not the embedded one), shared version of
Irrlicht. The cmake module to find those system libraries simply needs
an update and should look for the .so files in the right path. A similar
issue exists for the FindJson.cmake module. In general there should
always be a way to use system libraries instead of embedded code copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants