Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set viewing_range both equal for min and max #2644

Closed
kilbith opened this issue Apr 22, 2015 · 9 comments

Comments

@kilbith
Copy link
Contributor

commented Apr 22, 2015

Somehow it seems the game runs better and stabler on lower hardware in setting (example) :

viewing_range_nodes_min = 50
viewing_range_nodes_max = 50

Instead of just : viewing_range_nodes_min = 50

^ The latter case looks odd and unstable (viewing range randomly goings and comings -- FPS drops accordingly).

Therefore, pressing [+] or [-] ought set equals values for min and max.

@PilzAdam

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2015

What do you mean by "it runs better"? Maybe you just want to increase wanted_fps?

@kilbith

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2015

Maybe you just want to increase wanted_fps?

No-no... by "runs better" I meant that you have higher performances and smoother playing because there's no longer those weird viewing range randomly goings and comings from afar (_max ain't set by default).

@Sokomine can confirms it as well : here.

@kilbith kilbith changed the title Set viewing_range both equally for min and max Set viewing_range both equal for min and max Apr 24, 2015

@lightonflux

This comment has been minimized.

Copy link

commented Apr 24, 2015

I can confirm as well.

First i only had

viewing_range_nodes_min = 55
in the conf.

When i look at a jungle (many waving leaves) the framerate dropped to 28 - 35 fps.

When i added the following line it was in the 40 range sometimes dropping to 30-something but never below and mostly between 40-45.

viewing_range_nodes_max = 55

@Megaf

This comment has been minimized.

Copy link
Contributor

commented May 14, 2015

I can confirm that. Using the same value for max and min increase the gameplay a lot, makes it fluid.

Minetest will slowdown and hickup when switching from min to max back to min.

@Pilcrow182

This comment has been minimized.

Copy link

commented May 25, 2015

I can confirm this as well. It's always seemed like minetest takes quite a bit of power when calculating a new view range, especially on low-powered hardware. Every time it happens, the framerate spikes downward and back up. I've been playing with 50min/50max since 0.4.8, actually; it's been happening for a long time...

@kilbith

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2015

I still militate for those settings by default, as many people report a significant performance improvement with the same value on _min and _max.

@paramat

This comment has been minimized.

Copy link
Member

commented Aug 27, 2015

I set them equal myself, seems better.

@PilzAdam

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2015

Maybe the view range adjustment algorithm needs tweaking? @celeron55 usually does this.

@celeron55

This comment has been minimized.

Copy link
Member

commented Aug 28, 2015

Well it's probably impossible to make a markedly better algorithm. If you improve it for someone, it will be worse for someone else.

Just add these options to the GUI with an option to disable the adjusting algorithm (the GUI can disable it by setting such values that _min>=_max (if min>=max, min is always taken)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.