Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow bug at y = 63 in mgv5/mgv7/mgflat/mgfractal/mgvalleys(/mgwatershed) #2759

Closed
paramat opened this issue Jun 5, 2015 · 9 comments

Comments

Projects
None yet
4 participants
@paramat
Copy link
Member

commented Jun 5, 2015

screenshot_20151129_222541

Note there is light around the decorations. Affects mgv5, mgv7, mgflat, mgfractal, mgvalleys and mapgens in development which are based on mgv7 and have the same lighting code. Sometimes as mapchunks generate parts of the shadows appear and disappear.

These may have started around the time of this lighting change 7233a12 before which we had lighting bugs at y = 47.

See more details below.

@nanepiwo

This comment has been minimized.

Copy link

commented Jun 5, 2015

I've seen similar lighting glitches (shadows that can't be removed) but not at any specific elevation, with the default mapgen.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2015

Yes in 0.4.12 stable mgv6 has shadow glitches but those are from a different cause and have been fixed now.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2015

screenshot_20151204_054227

^ Testing in mgv7 with terrain surface fixed at y = 62. Light is normal around dry shrub decorations and tunnels but not around cacti, dry shrub propagates light while cactus does not.

This is still a mystery. From testing i have found this always occurs when the mapchunk above y = 47 is generated before the mapchunk below. When the lower mapchunk generates the shadows appear at y = 63 which is the top layer of nodes in the full voxelmanip volume of the mapchunk below (63 = 47 + 16).

Note the affected mapgens all use 1 up 1 down overgeneration.
Does not affect mgv6.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2015

I tried editing mgv7 to not overgenerate, and used the lighting call from mgv6:
calcLighting(node_min, node_max);
These shadows remain. So it's mysterious what is causing these, something about the mapgens based on mgv7.

@paramat paramat changed the title Lighting bug at y = 63 in mgv7 and core mapgens in development Shadow bug at y = 63 in mgv5/mgv7/mgflat/mgfractal/mgwatershed Dec 4, 2015

@duane-r

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2015

This affects Valleys C++, also a derivative of mgv7, at the same altitude.

example

@paramat paramat added the Blocker label Feb 17, 2016

@paramat paramat changed the title Shadow bug at y = 63 in mgv5/mgv7/mgflat/mgfractal/mgwatershed Shadow bug at y = 63 in mgv5/mgv7/mgflat/mgfractal/mgvalleys(/mgwatershed) Feb 18, 2016

@kahrl kahrl added this to the 0.4.14 milestone Feb 23, 2016

@paramat paramat removed the Blocker label Mar 12, 2016

@paramat

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2016

I plan to look at this once feature freeze starts.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

Hmmmm and i have discovered the cause, fix coming.
From IRC:

06:22 paramat maybe it's dusttopnodes
06:24 paramat remember i allowed dust to be placed near full_node_max.Y if the chunk above is generated
06:25 paramat maybe it's placing dark air as dust
06:27 paramat dust has a fallback value of "air", perhaps it should be "ignore"
06:29 paramat .. as dust = ignore disables the dust sprinkle search

06:55 paramat ok my idea about dust top nodes fixes this =O

07:03 paramat setting the dust fallback to "ignore" fixes this, so this is due to "air" being placed as a dust, due to biomes where dust is unspecified
07:05 paramat in dustTopNodes dust = ignore will disable dust placement

@paramat

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

@paramat

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

#4013 is merged.

@paramat paramat closed this Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.