Add MoveSomewhere inventory action #2808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
est31
force-pushed
the
movesomewhere
branch
3 times, most recently
from
764f4d7
to
07bb364
Compare
|
Ready for review. |
| for (u32 dest_i = 0; dest_i < dest_size; dest_i++) { | ||
| if (!m_items[dest_i].empty()) { | ||
| item1 = dest->addItem(dest_i, item1); | ||
| if (item1.empty()) break; |
There was a problem hiding this comment.
Add this condition into the for loop condition, it's more elegant.
Improve shift+click experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve shift+click experience. Needed because even if client prediction were perfect, the server can send an "updated" inventory before informations about the actually updated inventory came in, and fast shift-clickers will have swapped slots.
TODO: