Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font characters broken #2847

Closed
mahmutelmas06 opened this Issue Jun 27, 2015 · 15 comments

Comments

Projects
None yet
5 participants
@mahmutelmas06
Copy link
Contributor

mahmutelmas06 commented Jun 27, 2015

Turkish characters (probably other non ascii characters too ) is not shown as it should be since last week. There are just blanks instead of these characters. English characters are fine.

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jun 27, 2015

@SmallJoker has reported this too I think. He was willing to bisect (EDIT: perhaps I've mixed the bisect part with #2842).

@kilbith

This comment has been minimized.

Copy link
Contributor

kilbith commented Jun 27, 2015

What's your OS ?

@est31 est31 added the Bug label Jun 27, 2015

@mahmutelmas06

This comment has been minimized.

Copy link
Contributor Author

mahmutelmas06 commented Jun 27, 2015

Windows 7 64bit.
I have this issue only the builds from last week till now. There was no issue before.

@SmallJoker

This comment has been minimized.

Copy link
Member

SmallJoker commented Jun 27, 2015

Yes, I reported this bug in IRC after @mahmutelmas06 wrote a forum post about this issue.
Quoting myself:

Builds until June 6 are fine and those after June 21 are broken (+/- some days).

He pointed out that the build 502e40a worked, the fail must be between that commit and June 21, 622918d

It's a character issue -> a commit between 572990d and d105bf2 @est31

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jun 27, 2015

Does it work with irrlicht 1.9?

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jun 27, 2015

So, how does the bug manifest? can you enter turkish characters in chat? can you show a screenshot, before after?

@est31 est31 added the Windows label Jun 27, 2015

@mahmutelmas06

This comment has been minimized.

Copy link
Contributor Author

mahmutelmas06 commented Jun 28, 2015

Here is the screenshot. All was nice with stefan's latest build.
Both chat and menu are broken.

screen

@SmallJoker

This comment has been minimized.

Copy link
Member

SmallJoker commented Jun 30, 2015

I alias'ed utf8_to_wide with narrow_to_wide and wide_to_utf8 with wide_to_narrow in string.cpp, it solved the problem on here.
But now it's no longer UTF8...

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jun 30, 2015

Great, that's the emergency fix for 0.4.13 then, if nobody with access to windows takes care of this until 0.4.13.

@est31 est31 added this to the 0.4.13 milestone Jun 30, 2015

@Moufu5

This comment has been minimized.

Copy link
Contributor

Moufu5 commented Jul 3, 2015

I have this problem too.

before:
minetest _001
after:
minetest _002

How can I disable the UTF-8 conversion?

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jul 3, 2015

It will be disabled with a non-proper solution for 0.4.13, if nobody with enough knowledge can fix the issue. I have no windows box to test this.

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jul 3, 2015

about how to disable it for you personally: do it like 60f31ad

@Moufu5

This comment has been minimized.

Copy link
Contributor

Moufu5 commented Jul 3, 2015

I dont know C language (C ++) .
Is it possible to disable it by changing the latest code?

This was referenced Jul 5, 2015

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jul 8, 2015

Can you try now, 2891 got merged.

@est31

This comment has been minimized.

Copy link
Contributor

est31 commented Jul 10, 2015

Fixed, as @SmallJoker confirms

@est31 est31 closed this Jul 10, 2015

est31 added a commit to est31/minetest that referenced this issue Jul 16, 2015

Use UTF-8 for chat
-> Add and activate protocol version 26
-> Use utf-8 for chat, always
-> Fixes regression for windows (issue minetest#2847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.