Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'new style water' and waving water. #3759

Closed
paramat opened this issue Feb 21, 2016 · 12 comments

Comments

Projects
None yet
8 participants
@paramat
Copy link
Member

commented Feb 21, 2016

See discussion #3734
As both have problems, are embarassing and are unusable now we have water surface decorations.
RealBadAngel has plans for better water shaders.
PR for removing new style water #3760
Removing waving water is more complex and involves #3616

@est31

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2016

Removing waving water doesnt involve 3616 at all, from what I've seen.

@est31

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2016

But I agree to have new style and waving water removed, and that that's a blocker, I don't think however that having better water shaders is a blocker though.

@paramat

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2016

Removing waving water doesnt involve 3616 at all

Yes that's what i said to RBA, i asked that the removal of waving water be seperate from 3616, so that we can continue to discuss 3616 and possible future water shaders later.

@PilzAdam

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2016

I think that the shader effect is easily fixable.

IIRC there was already a patch (maybe it was even merged) that rendered the top-side of liquids if solid nodes are above it when new_style_water is enabled. This could be expanded to work with shaders, too (this is quite trivial).

The initial problem of #3734 only happens if new_style_water and the shader effect are enabled both at once, which of course wouldn't happen anymore if new_style_water is removed.

@cheapie

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2016

So the proper action when a feature isn't just right is just to remove it now?

(besides, I'd think just implementing some way to wave the decorations too would be easier)

@0-afflatus

This comment has been minimized.

Copy link

commented Feb 21, 2016

So the proper action when a feature isn't just right is just to remove it now?

On some level, yes. You make this sound like it's a trivial decision - I liked new_style water and the waving effect, but there are so many problems associated with it that needed fixing. On the run-up to a release, it's much cleaner to remove broken features as that leaves a clean, stable base on which the feature could be properly re-implemented and / or the gaps left by its removal can be clearly seen.

Were it just the case that water-lilies and seaweed didn't move with the water then maybe.

@RealBadAngel

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2016

about #3616, it cleans the mess a bit, by removing hardcoded water shaders for default water, and letting mods define it.
so with it i can simply delete "water_surface_shader", fix the nodes one (remove waving there) and in the future when needed add specialized one for water of any kind

i can remove waving water without 3616 but the mess remains. if you want me to clean it, let me do it proper way

@paramat

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2016

I think that the shader effect is easily fixable.

The issue with waving water is that it is perhaps not usable now we have water surface decorations. RBAs new approach, which i prefer, is to keep water surface fixed and use shaders to animate the surface texture.

@est31

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2016

Note that I oppose waving water out of other reasons, decorations aren't really the reason for it (they can just as simply be disabled from mapgen with the same argumentation -- now as we have waving water we cant have decorations). After all water decorations are a game thing.

@kahrl kahrl added this to the 0.4.14 milestone Feb 23, 2016

@paramat paramat removed the Blocker label Mar 12, 2016

@paramat paramat removed this from the 0.4.14 milestone Mar 12, 2016

@paramat paramat removed the High priority label Mar 12, 2016

@paramat

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2016

Removing milestone as new style water has been removed. Removing or fixing waving water doesn't seem particularly essential for release and may take some time.

@MirceaKitsune

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2016

Please don't remove the waving water or leaves as a feature! Some of us really like them and are using them, we don't want them to go away. If there's a problem with them, that problem should be fixed. 👎 !

@paramat

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2016

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.