Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player immortal while attached #4484

Closed
tenplus1 opened this issue Aug 29, 2016 · 8 comments
Closed

Player immortal while attached #4484

tenplus1 opened this issue Aug 29, 2016 · 8 comments
Labels
Bug Issues that were confirmed to be a bug

Comments

@tenplus1
Copy link
Contributor

It turns out that while the player is attached to an entity (boat, cart) they are immune to attack by other players and mobs. The minetest.register_on_punchplayer() function is never called. This is quite a bad problem.

@paramat paramat added the Bug Issues that were confirmed to be a bug label Aug 29, 2016
@stujones11
Copy link
Contributor

I think this is due to the fact that attached entities do not have a collision-box

Related #2851

@Megaf
Copy link
Contributor

Megaf commented Oct 4, 2016

We've just confirmed the bug here. Can't be harmed by sword attacks if you are on boats for example.

@Fixer-007
Copy link
Contributor

Fixer-007 commented Oct 4, 2016

Confirmed.

@SmallJoker
Copy link
Member

SmallJoker commented Oct 6, 2016

Does anyone know why this check was added?
https://github.com/minetest/minetest/blob/master/src/content_sao.cpp#L445

@Megaf
Copy link
Contributor

Megaf commented Oct 6, 2016

Maybe if a player dies while attached something bad happens?

@stujones11
Copy link
Contributor

stujones11 commented Oct 8, 2016

@SmallJoker no idea but it looks like it's been that way ever since the attachment system was added. 948b5a8#diff-da1e28445fc732755d2b64683bd94ee4R1081

Maybe because of this?

// Attachments need to be handled on both the server and client.
// If we attach only on the server, models (which are client-side)
// can't be read so we don't know the origin and orientation of bones.
// If we attach only on the client, the real position of attachments is
// not updated and you can't click them for example.

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Aug 3, 2017

Can this be added to the 0.5.0 milestone? This bug is quite serious.

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented May 1, 2018

Fixed via #6786.
This can now be closed.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that were confirmed to be a bug
Projects
None yet
Development

No branches or pull requests

8 participants