Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Make client timeout if RTT < 0. #4564

Open
Megaf opened this issue Oct 2, 2016 · 11 comments

Comments

Projects
None yet
6 participants
@Megaf
Copy link
Contributor

commented Oct 2, 2016

Hi, I was playing now and there was a lag spike on the server side, that made the server time out all the clients. But nobody noticed, clientes never got the timeout message, server was still up, was just a spike.

But one of the players and then me noticed the RTT = -1. That's a good indication that the client should time out.

@rubenwardy

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

This is always irritating. It should at least display some notification that the server hasn't replied in X (5<X<20) seconds

@Fixer-007

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2017

+1 Very irritating issue.

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2017

And this is not very hard to implement, is it?

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2017

We need more comments on this issue please.

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2017

Ok, tell me what file I have to change and how to do it and I will do it myself...

@paramat

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

Folding #1654 into this.

@twoelk

This comment has been minimized.

Copy link

commented Dec 9, 2017

could https://github.com/crazyginger72/minetest_time or https://github.com/BrunoMine/latent be usefull for this?
or is this a good example for (gulp) a
client-side-mod usecase?

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2017

https://github.com/crazyginger72/minetest_time/blob/master/init.lua
That could be added to builtin perhaps, with some changes.
All I want is a simple if/then check.

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2018

@paramat Shouldn't I just close this? Not a lot of interest from people in this as it seems.

@ThomasMonroe314

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2018

I suppose if the RTT drops below zero everytime there is a lag spike then +1 from me

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2018

RTT is Round Trip Time. Is the time it takes for "signal" to travel from client to server and back to client. It's the actual network based ping.
So it's kinda obvious, IMHO, way of telling if the network has stopped working or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.