Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block loading bug at small view range #4878

Closed
juhdanad opened this issue Dec 10, 2016 · 11 comments
Closed

Block loading bug at small view range #4878

juhdanad opened this issue Dec 10, 2016 · 11 comments
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug
Milestone
0.4.15

Comments

@juhdanad
Copy link
Contributor

How to reproduce:

  1. go to an undergeround cave
  2. log out
  3. set view range to 20
  4. log in

Underground blocks may not load on login.
@est31
Copy link
Contributor

est31 commented Dec 10, 2016

cc @lhofhansl

@est31 est31 added the Bug Issues that were confirmed to be a bug label Dec 10, 2016
@sfan5 sfan5 added this to the 0.4.15 milestone Dec 10, 2016
@lhofhansl
Copy link
Contributor

will have a look later

@lhofhansl
Copy link
Contributor

@juhdanad

  • Only in caves? Above ground blocks are rendered?
  • Does this only happen with latest git, or also with 0.4.14?

@lhofhansl
Copy link
Contributor

lhofhansl commented Dec 10, 2016 •
edited

Looks like there's a problem when max_block_send_distance is 1. We should force it to a minimum of 2.
Perhaps related to #4765 @Rogier-5 ?

Easiest seems to force minimum of 2 map blocks on top of the change in #4811

@juhdanad
Copy link
Contributor Author

Sometimes I bump into invisible inexistent blocks near to the place I logged in on the surface too. But it is much easier to reproduce underground. I tried with an older version (about 3-4 months old) and the bug appeared then, too.

@lhofhansl
Copy link
Contributor

OK... Nothing recent then. At least I know where not to look. :)

What your server's max_block_send_distance and max_block_generate_distance?

@juhdanad
Copy link
Contributor Author

max_block_send_distance=9
max_block_generate_distance=7

@Rogier-5 Rogier-5 mentioned this issue Dec 10, 2016
Merged
@Rogier-5
Copy link
Contributor

Bisected to commit 5dc6198:
Optimize/adjust blocks/ActiveObjects sent at the server based on client settings. (#4811)

Can't reproduce it on earlier versions.

Pushed a possible fix. @juhdanad: Could you verify whether it fixes the problem, or whether your problem is a different one or maybe a dual one ?

Rogier-5 added a commit to Rogier-5/minetest that referenced this issue Dec 10, 2016
@Rogier-5
Fix computation of viewing range (in blocks) sent to server
6c2c75c 
Fixes minetest#4878

Also remove an artificial viewing range reduction that
(presumably) was added to compensate for miscomputed
viewing ranges, and that doesn't seem to be needed any
more (thanks to lhofhansl).
@paramat
Copy link
Contributor

paramat commented Dec 11, 2016 •
edited

With view range 20 it's normal for nearby blocks to not load in, however i did quickly find a block that refused to load in despite walkiing against it. It only loaded once view range was > 30.

screenshot_20161211_003431

@est31 est31 added the Blocker The issue needs to be addressed before the next release. label Dec 11, 2016
@est31
Copy link
Contributor

est31 commented Dec 11, 2016

I think this is important enough to warrant the blocker label, and if its not fixed before release we still can revert the commits that caused the regression.

@paramat
Copy link
Contributor

paramat commented Dec 11, 2016 •
edited

I find that sometimes after 20-30s the missing blocks load in.

est31 pushed a commit that referenced this issue Dec 11, 2016
@Rogier-5 @est31
Fix computation of viewing range (in blocks) sent to server (#4882)
6077207 
Fixes #4878

Also remove an artificial viewing range reduction that
(presumably) was added to compensate for miscomputed
viewing ranges, and that doesn't seem to be needed any
more (thanks to lhofhansl).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker The issue needs to be addressed before the next release. Bug Issues that were confirmed to be a bug
Projects
None yet
Milestone
0.4.15
Development

No branches or pull requests
6 participants
@lhofhansl @sfan5 @paramat @Rogier-5 @est31 @juhdanad