Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New movement code sneak related problems (table of bugs) #5535

Closed
Fixer-007 opened this issue Apr 7, 2017 · 16 comments
Closed

New movement code sneak related problems (table of bugs) #5535

Fixer-007 opened this issue Apr 7, 2017 · 16 comments

Comments

@Fixer-007
Copy link
Contributor

@Fixer-007 Fixer-007 commented Apr 7, 2017

List of sneak related bugs (work in progress, updated 14Sep2018)
I've tried to catch most of the issues posted, this may be useful during this epoch of fixing sneak problems.

Issues:
#5438 Sneaking on 1/16th slab bug, and other sneak issues / mostly fixed, only minor issues remain
#5861 Can jump over nodes with height of 1.5 by sneaking
#7725 "New" movement code bugs

@Fixer-007

This comment has been minimized.

Copy link
Contributor Author

@Fixer-007 Fixer-007 commented Apr 11, 2017

@paramat and Co
I've retested #329 on clean game and it looks like bugs I posted were invalid since I didn't wait for 3 seconds of cooldown that disables the damage after teleportation, I've tried to evade many times, including on edges and jumping on slabs/stairs/doors without luck, so I requested to close that issue (and it was).

There must be a decision about that 3 seconds cooldown, if it is needed at all.
It will be also nice to include krocks fix for teleport to center of stair when sneaking and some other stuff.

#5449 Krock has a fix for that

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Apr 12, 2017

@Fixer-007 this #329 (comment) is no longer an issue?

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Apr 12, 2017

#2774 is not a sneak issue as it happens when sneak is disabled, it's just a bug in that part of the code:

It appears that disable_jump does not work correctly when the player attempting to jump has no sneaking capability (player:set_physics_override({sneak=false})).

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Apr 12, 2017

Once #5449 is fixed all that remains is #5438 see the list of remaining issues here #5438 (comment) some of those may be fixed by Krock's code.

@Fixer-007

This comment has been minimized.

Copy link
Contributor Author

@Fixer-007 Fixer-007 commented Apr 12, 2017

this #329 (comment) is no longer an issue?

No longer an issue, I've tried to reproduce it many times and failed (the reason it worked before was 3 second cooldown), if you wait >3 seconds after teleport - it is not possible to do it anymore it seems.

@ClaudiusMinimus

This comment has been minimized.

Copy link

@ClaudiusMinimus ClaudiusMinimus commented Apr 24, 2017

It seems the sneak ladder feature/glitch has been disabled for the 0.4.15-dev; how do I re-enable sneak ladders?

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Apr 24, 2017

It has, i'll add a forum post soon.

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented May 23, 2017

Current situation: Only remaining issues are detailed in #5438 ...

"Current remaining issues:

"falling down if the node forward down is walkable but a nodebox."
"Confirmed, if on a flat surface you have a full node next to a snow slab and sneak towards the snow sneak fails."

"You can't walk across a default:snow or a 1/16 node while holding shift. To see this: drop a single node of default:snow on a flat surface, stand on the edge, hold shift and try to walk over it. You walk into an invisible wall and can't cross with shift held."

"Actually the biggest new problem in my opinion is that you can't jump if you are sneaking over the edge."

Sneak distance being smaller, 0.29 instead of 0.4.

Cannot sneak around corners of 1-node-high grooves in a wall.

1 Is a minor issue, you land on the nodebox below.
2 Was also present in old code, although the invisible barrier was smaller. A fairly minor issue anyway.
4 Seems an issue of getting used to the slightly smaller sneak distance, not a bifg issue."

SmallJoker is working on #5533 which may fix points 3 and 5 above which are the only remaining major issues.

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Jul 22, 2017

#5533 merged so points 3 and 5 are fixed.
That also fixes taking damage when sneaking out over a void in a nodebox.

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Jul 22, 2017

Current remaining issues:

"falling down if the node forward down is walkable but a nodebox."
"Confirmed, if on a flat surface you have a full node next to a snow slab and sneak towards the snow sneak fails."

"You can't walk across a default:snow or a 1/16 node while holding shift. To see this: drop a single node of default:snow on a flat surface, stand on the edge, hold shift and try to walk over it. You walk into an invisible wall and can't cross with shift held."

Sneak distance being smaller, 0.29 instead of 0.4.

1 Is a minor issue, you land on the nodebox below.
2 Was also present in old code, although the invisible barrier was smaller. A fairly minor issue anyway.
3 Seems an issue of getting used to the slightly smaller sneak distance, not a big issue.

All remaining issues are minor.

@Megaf

This comment has been minimized.

Copy link
Contributor

@Megaf Megaf commented Dec 9, 2017

Add #6727

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Dec 9, 2017

I think we can close this now, as there are very few issues and PRs left.

@Megaf

This comment has been minimized.

Copy link
Contributor

@Megaf Megaf commented Dec 9, 2017

I like this list, maybe it could have only the unsolved stuff there though, and remove the strikethrough ones.

@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Dec 9, 2017

Will do.

@paramat paramat removed the Low priority label Dec 9, 2017
@Megaf

This comment has been minimized.

Copy link
Contributor

@Megaf Megaf commented Dec 9, 2017

@paramat Thank you. It looks better now in my opinion. And more clear what still has to be fixed.

@paramat paramat changed the title Sneak related problems (table of bugs) New movement code sneak related problems (table of bugs) Sep 14, 2018
@paramat

This comment has been minimized.

Copy link
Member

@paramat paramat commented Feb 8, 2019

Closed as duplicating issues like this is a pain for issue management. The 3 linked issues are open.

@paramat paramat closed this Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.