Main Menu: Add get_clientmodpath API #5912
Conversation
Add `core.get_clientmodpath` to main menu API (also possible in async calls).
|
Should wait until #5915 is addressed. |
|
@paramat your argument is totally wrong. It's just and API to get mod path for main menu, thanks for having read the description properly. |
|
What i mean is that 5915 is the priority now, this PR is probably fine but some features of CSM should not develop further until 5915 is addressed. Clientmods are already beginning to ruin servers. |
|
Ok my -1 is not reasonable, removed, but my opinion remains the same, please work on 5915 first. |
|
you cannot block a PR because you want another to be fixed and there is no solution, stop that now and code a good solution based on comments on the other PR. |
|
👍 |
This reverts commit fee5171.
|
@nerzhul i know and i agree, i don't -1 this PR anymore, and that was unreasonable of me, sorry to all. |
Add `core.get_clientmodpath` to main menu API (also possible in async calls).
Add `core.get_clientmodpath` to main menu API (also possible in async calls).
Add
core.get_clientmodpathto main menu API (also possible in async calls).Though not required, this is important to allow a proper way for my WIP
modmgrrewrite to manage client side mods. And yes, I am now aware of the fact that the client loading CSMs wasn't originally planned, however, I personally think it is very important. A mod like the new who_plus wouldn't be inserted as a CSM by the server, it just doesn't make since. It would be optionally installed by the client.