New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check item_drop amount clientside #6242
Conversation
cb95566
to
7608f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested 👍
|
7608f5a
to
bf068aa
Compare
src/game.cpp
Outdated
@@ -2655,10 +2655,12 @@ void Game::processItemSelection(u16 *new_playeritem) | |||
} | |||
|
|||
|
|||
void Game::dropSelectedItem() | |||
void Game::dropSelectedItem(bool single_item) | |||
{ | |||
IDropAction *a = new IDropAction(); | |||
a->count = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ternary operator ? you set count twice
sounds okay, i prefer to have the sneak check client side, server side can be inaccurate, just fix the two a->count assignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay for this if a->count double assignment is fixed
bf068aa
to
52bff94
Compare
@nerzhul done |
No description provided.