Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version model #6266

Closed
nerzhul opened this issue Aug 18, 2017 · 8 comments

Comments

@nerzhul
Copy link
Member

commented Aug 18, 2017

Our current version model for dev uses the following scheme [last-released-version]-dev

This has two big cons:

  • Users seems to understand it's the last released version stable build or production grade
  • We cannot develop or distinguish on which branch version we are working (stable-0.4 vs master which is on the 0.5 way)

I suggested times ago to switch to [next-release-version]-dev instead, it will permit to have 0.5.0-dev (which is clearly a dev build on the next major version) and 0.4.17-dev on stable-0.4 to release 0.4.17 bugfix patch later

please vote on the issue adding 👍 or 👎 in this message

@nerzhul

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2017

@minetest/team-minetest please vote on this issue

@paramat

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

@celeron55 seems ok with it, see http://irc.minetest.net/minetest-dev/2017-08-15#i_5044350 and discussion before that.

@nerzhul

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2017

note: https://github.com/minetest/minetest/blob/master/util/bump_version.sh should be changed if motion is accepted

@nerzhul

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2017

currently there is 4 coredevs approval + celeron55 approval on IRC

@paramat

This comment has been minimized.

Copy link
Member

commented Aug 18, 2017

And c55's thumbs-up in first post.

@Wuzzy2

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2017

I will only give my thumbs up if the new versioning scheme is:

a) sufficiently documented in prominent places (dev.minetest.net, text files in doc/, etc.) or
b) officially switched to SemVer (http://semver.org/), and it is officially mentioned in a prominent place that you follow SemVer

Otherwise I'm neutral.

@nerzhul

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2017

PR #6292

@nerzhul

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2017

Fixed

@nerzhul nerzhul closed this Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.