Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapgen Carpathian: Reduce influence of 3D noise on mountains #6360

Merged
merged 1 commit into from Sep 2, 2017

Conversation

vlapsley
Copy link
Contributor

@vlapsley vlapsley commented Sep 1, 2017

Addresses issue #6349

Three minor changes to mountains:

  • Remove 3D noise from the GetSteps function
  • Hardcode the step width to 0.5 in the getSteps function.
  • Lower persistence in the 3D noise variation for all mountains 0.6 -> 0.55 to reduce chance of floating blobs of stone

@paramat
Copy link
Contributor

paramat commented Sep 1, 2017

Reducing the influence of 3D noise may reduce floating stone, but it also reduces the chance of interesting shapes, arches, overhangs, so it's a difficult balance. I recommend not trying to completely avoid floating stuff. Persistence 0.55 is fairly smooth and not so good for interesting detail.

You have lots of time to tune the mapgen, 0.5 release is late December at the earliest. So feel free to keep making tuning PRs.
Are you sure you're happy with this? No rush.

@paramat
Copy link
Contributor

paramat commented Sep 1, 2017

Code is fine.

@paramat
Copy link
Contributor

paramat commented Sep 1, 2017

I would prefer that persistence is not reduced, but i'm +1 for all other changes.
Maybe leave tuning persistence to a later PR so that you can spend more time finding a balance?
So, i approve the PR if persistence is not reduced in this PR.

@paramat
Copy link
Contributor

paramat commented Sep 2, 2017

If you're sure about the persistence reduction then 👍

@SmallJoker
Copy link
Member

Tested. The floating stones are gone - the mountains look smoother now. Found a few 3D overhangs, which haven't changed much from before/afterwards.
👍

@nerzhul nerzhul merged commit 2ac5a45 into minetest:master Sep 2, 2017
@vlapsley vlapsley deleted the carp-terrace branch September 4, 2017 05:30
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants