Auth handler: Player deletion & Iterator #6741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerzhul
approved these changes
Dec 5, 2017
SmallJoker
approved these changes
Dec 5, 2017
rubenwardy
requested changes
Dec 5, 2017
doc/lua_api.txt
Outdated
| * Returns a code (0: successful, 1: no such player, 2: player is connected) | ||
| * `minetest.remove_player_auth(name)`: remove player authentication data | ||
| * Returns boolean indicating success |
There was a problem hiding this comment.
should note that it will return false if the player doesn't exist
There was a problem hiding this comment.
i thought that was obvious since you can't successfully remove a nonexistant player
will add though
There was a problem hiding this comment.
I've seen similar (non-MT) APIs doing it either way, so it's good to mention
doc/lua_api.txt
Outdated
| @@ -5225,6 +5228,8 @@ Definition tables | |||
| create_auth = func(name, password), | |||
| -- ^ Create new auth data for player `name` | |||
| -- ^ Note that `password` is not plain-text but an arbitrary representation decided by the engine | |||
| delete_auth = func(name), | |||
| -- ^ Delete auth data of player `name`, returns boolean indicating success | |||
rubenwardy
requested changes
Dec 5, 2017
doc/lua_api.txt
Outdated
| @@ -3124,8 +3124,11 @@ These functions return the leftover itemstack. | |||
| * `minetest.get_server_status()`: returns server status string | |||
| * `minetest.get_server_uptime()`: returns the server uptime in seconds | |||
| * `minetest.remove_player(name)`: remove player from database (if he is not connected). | |||
| * Does not remove player authentication data, minetest.player_exists will continue to return true. | |||
| * As auth data is not removed, minetest.player_exists will continue to return true. | |||
| Call the below method if you want to remove auth data too. | |||
There was a problem hiding this comment.
Call the below method as well
There was no way to do this previously and a recent commit broke doing this the "hacky" way by accessing `core.auth_table`.
rubenwardy
approved these changes
Dec 5, 2017
t0ny2
pushed a commit
to t0ny2/minetest
that referenced
this pull request
Jan 23, 2018
* Add player deletion method to auth handler (fixes minetest#6653) * Support iterating over the auth database There was no way to do this previously and a recent commit broke doing this the "hacky" way by accessing `core.auth_table`.
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
* Add player deletion method to auth handler (fixes minetest#6653) * Support iterating over the auth database There was no way to do this previously and a recent commit broke doing this the "hacky" way by accessing `core.auth_table`.
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
* Add player deletion method to auth handler (fixes minetest#6653) * Support iterating over the auth database There was no way to do this previously and a recent commit broke doing this the "hacky" way by accessing `core.auth_table`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.