Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from clang 5.0 to 7.0 + Add GCC 8 #7159

Merged
merged 2 commits into from Mar 14, 2019
Merged

Upgrade from clang 5.0 to 7.0 + Add GCC 8 #7159

merged 2 commits into from Mar 14, 2019

Conversation

nerzhul
Copy link
Member

@nerzhul nerzhul commented Mar 23, 2018 •
edited

This permits to have more features in clang-format + up-to-date clang.

See also why we need to set a new clang-format variable: https://travis-ci.org/minetest/minetest/jobs/357587622

@nerzhul nerzhul added the @ Build CMake, build scripts, official builds, compiler and linker errors label Mar 23, 2018
@nerzhul nerzhul added this to the 0.5.0 milestone Mar 23, 2018
@nerzhul nerzhul requested a review from sfan5 March 23, 2018 10:30
@nerzhul nerzhul changed the title Use clang 6 for linter & non freetype builds Upgrade from clang 5.0 to 6.0 Mar 23, 2018
@nerzhul nerzhul added this to Feature PR in Minetest 5.0.0 blockers Mar 24, 2018
@sfan5 sfan5 added the WIP The PR is still being worked on by its author and not ready yet. label Mar 25, 2018
@sfan5 sfan5 removed the WIP The PR is still being worked on by its author and not ready yet. label Mar 29, 2018
sfan5
sfan5 reviewed Mar 29, 2018
View reviewed changes
util/travis/common.sh Outdated Show resolved Hide resolved
sfan5
sfan5 approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-

@nerzhul
Copy link
Member Author

nerzhul commented Mar 29, 2018

Currently build doesn't pass i'm trying to fix it

@sfan5
Copy link
Member

sfan5 commented Mar 29, 2018

Oh sorry didn't see.

@sfan5 sfan5 added the WIP The PR is still being worked on by its author and not ready yet. label Mar 29, 2018
@SmallJoker SmallJoker added the Rebase needed The PR needs to be rebased by its author. label Apr 7, 2018
@nerzhul nerzhul removed the Rebase needed The PR needs to be rebased by its author. label Jun 1, 2018
@nerzhul
Copy link
Member Author

nerzhul commented Jun 1, 2018

rebase done + clang tidy update too

@paramat paramat removed this from PR in Minetest 5.0.0 blockers Aug 20, 2018
@nerzhul nerzhul modified the milestones: 5.0.0, 5.1.0 Dec 22, 2018
@nerzhul nerzhul changed the title Upgrade from clang 5.0 to 6.0 Upgrade from clang 5.0 to 7.0 Mar 12, 2019
@nerzhul nerzhul removed the WIP The PR is still being worked on by its author and not ready yet. label Mar 12, 2019
@nerzhul nerzhul changed the title Upgrade from clang 5.0 to 7.0 Upgrade from clang 5.0 to 7.0 + Add GCC 8 Mar 12, 2019
@nerzhul
Copy link
Member Author

nerzhul commented Mar 12, 2019

@sfan5 please re-review, now it's working properly :)

@nerzhul nerzhul requested a review from sfan5 March 12, 2019 15:41
sfan5
sfan5 reviewed Mar 12, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
sfan5
sfan5 reviewed Mar 12, 2019
View reviewed changes
util/travis/clangtidy.sh Outdated Show resolved Hide resolved
@nerzhul
Copy link
Member Author

nerzhul commented Mar 14, 2019

@sfan5 comments are fixed. I'm trying to make the link between scripts & travis more simple

@nerzhul
Update our tooling (Clang 5 -> 7, GCC 7 -> 8)
2c941d9 
This change permits to use up-to-date compilers, clang-tidy and
clang-format

It also refactor the tidy/format step to drop the binary selection from
scripts and perform it directly in travis
@nerzhul
LINT fixes since recent tooling update
0225140
@nerzhul nerzhul requested a review from sfan5 March 14, 2019 10:51
@nerzhul nerzhul merged commit 02a2389 into minetest:master Mar 14, 2019
@nerzhul nerzhul deleted the clang_6 branch March 14, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors One approval ✅ ◻️
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nerzhul @sfan5 @SmallJoker