Pointed_thing_to_face_pos: Fix crash when inside a node #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clang tidy seems broken @nerzhul here and in other recent commits: |
SmallJoker
reviewed
May 16, 2018
builtin/common/misc_helpers.lua
Outdated
| @@ -685,6 +685,12 @@ end | |||
| -- Returns the exact coordinate of a pointed surface | |||
| -------------------------------------------------------------------------------- | |||
| function core.pointed_thing_to_face_pos(placer, pointed_thing) | |||
| -- Avoid crash when head is inside a non-walkable and buildable_to node, | |||
There was a problem hiding this comment.
Not necessary a non-walkable and buildable_to node. It can be any node if the player placed into themselves (minetest.conf setting).
There was a problem hiding this comment.
Ah ok, will update.
There was a problem hiding this comment.
In testing, it doesn't crash when inside a normal cube node, using 'build where stand'. However will make comment less specific.
Avoid crash in some situations when player is inside a node, causing 'above' to equal 'under'. In this situation return 'under' which is the node position very close to the face position that would normally be returned.
|
Updated comment to be less specific. |
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
…inetest#7342) Avoid crash in some situations when player is inside a node, causing 'above' to equal 'under'. In this situation return 'under' which is the node position very close to the face position that would normally be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6643 Avoid crash when head is inside a non-walkable and buildable_to node,
causing 'above' to equal 'under'.
In this situation return 'under' which is a vector very close to what
would be returned if not inside the node.
//////////////////
For #6643
Tested.
To reproduce crash in MTG:
Enable free move, fly down a little, and place a stair or slab while player head is inside long grass, dry shrub, junglegrass etc.
With PR, the result is suitable and intuitive: the stair or slab is placed where the plantlike node is.
The issue suggested returning
vector.new()(a zero vector). Although that has the same suitable result in the 'stairs' mod it may be unsuitable for other mods. Normally a float position vector is returned that is the point on the node's face, so i chose to returnpointed_thing.underwhich is the integer position vector of the node itself.