Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust some settings to modern environments and networks. #7549

Merged
merged 1 commit into from Jul 13, 2018
Merged

Adjust some settings to modern environments and networks. #7549

merged 1 commit into from Jul 13, 2018

Conversation

lhofhansl
Copy link
Contributor

This goes together with #7548 and fixes #7401 .

  • emergequeue_limit_generate, doubled to 64
  • emergequeue_limit_diskonly, doubled to 64
  • emergequeue_limit_total, doubled to 512
  • num_emerge_threads, change default to 0 (pick a good value based on H/W)
  • max_simultaneous_block_sends_per_client, quadrupled to 40 (this can even be higher, but let's be a bit conservative)

@lhofhansl lhofhansl requested a review from paramat July 13, 2018 07:26
@SmallJoker SmallJoker added @ Startup / Config / Util Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Jul 13, 2018
sfan5
sfan5 approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@lhofhansl
Copy link
Contributor Author

I confirmed that max_simultaneous_block_sends_per_client of 40 is good for reasonable RTTs of up to 40ms.

@nerzhul
Copy link
Member

nerzhul commented Jul 13, 2018

Agree too

@nerzhul nerzhul merged commit a95aed8 into minetest:master Jul 13, 2018
@lhofhansl
Copy link
Contributor Author

Oops. Needs an amendment to change minetest.conf.example.

@lhofhansl lhofhansl mentioned this pull request Jul 13, 2018
Closed
@SmallJoker
Copy link
Member

@lhofhansl The minetest.conf.example file can be generated automatically using the settingtypes file. This will happen at the very latest when 5.0.0 gets released.

@paramat
Copy link
Contributor

paramat commented Jul 14, 2018

We auto-generate .conf regularly so don't bother :)

@lhofhansl lhofhansl deleted the better-settings branch August 8, 2018 14:57
ClobberXD pushed a commit to ClobberXD/minetest that referenced this pull request Aug 17, 2018
@lhofhansl @ClobberXD
Adjust some settings to modern environments and networks. (minetest#7549
138eefd 
)
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@lhofhansl @osjc
Adjust some settings to modern environments and networks. (minetest#7549
ed88d77 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@paramat paramat Awaiting requested review from paramat

Assignees
No one assigned
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️ @ Startup / Config / Util
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase default max_simultaneous_block_sends_per_client
5 participants
@lhofhansl @nerzhul @SmallJoker @paramat @sfan5