Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (6)
@SmallJoker SmallJoker May 5, 2021
Really? Padding was necessary to get the skinsdb updater to work, hence commit f34abaedd2. I believe this should state 5.4.0.
Outdated
doc/lua_api.txt
SmallJoker appgurueu
@sfan5 sfan5 Mar 31, 2021
shouldn't `actual_padding == 0` cause none of these checks to be ran?
Outdated
src/util/base64.cpp
sfan5 appgurueu
@sfan5 sfan5 Mar 31, 2021
(same)
Outdated
doc/lua_api.txt
@sfan5 sfan5 Mar 31, 2021
```suggestion * Before 5.5.0 this function did not accept padding and returned nil ```
Outdated
doc/client_lua_api.txt
@numberZero numberZero Oct 20, 2020
> Omission of padding characters is allowed but how do you handle that?
Outdated
src/util/base64.cpp
appgurueu
@numberZero numberZero Oct 20, 2020
...yet `isalnum` is locale-dependent.
Outdated
src/util/base64.cpp
appgurueu