Nice work!

Jump to conversation

Unresolved conversations (0)

Nice work!

All of your conversations have been resolved.

Resolved conversations (10)

(made function static and added two asserts) ```suggestion #include <cassert> #include "util/serialize.h" #include "serialization.h" #include "irrlichttypes.h" static void writeChunk(std::ostringstream &target, const std::string &chunk_str) { assert(chunk_str.size() >= 4); assert(chunk_str.size() - 4 < U32_MAX); writeU32(target, chunk_str.size() - 4); // Write length minus the identifier ```

src/util/png.cpp

cannot we use directly libpng for this ? it's one of our dependencies

src/util/png.cpp

We have `irrlichttypes.h` that does what these two lines do, better to use that

src/util/png.cpp

I don't know where it makes a difference but these should be created as `std::ostringstream foo(std::ios::binary);`

src/script/lua_api/l_util.cpp

`readParam<int>`

src/script/lua_api/l_util.cpp

And generally I think the implementation here can better live somewhere in `src/util/`.

src/script/lua_api/l_util.cpp

Just use `writeU32(file, 0x0d)`? same works for the rest

src/script/lua_api/l_util.cpp

src/script/lua_api/l_util.cpp

Huh, why is that?

doc/lua_api.txt

Code style: * no `;` * spacing around operators * `end` never on same line

builtin/game/misc.lua