Jump to conversation

Unresolved conversations (1)

SmallJoker

Dec 12, 2021

Wouldn't it be more efficient to use the mod name as table name, rather than a separate column?

src/database/database-sqlite3.cpp

Resolved conversations (10)

celeron55

Jan 2, 2022

I don't like how much stuff this header pulls into this header for just getting StringMap. In the long term this ends up increasing compile times.

src/database/database.h

celeron55

Jan 2, 2022

Not that this error actually ever happens, but isn't the error message kind of weird?

Outdated

src/database/database-sqlite3.cpp

SmallJoker

Dec 14, 2021

`store` must be deleted if this returns `false`.

Outdated

src/script/lua_api/l_storage.cpp

SmallJoker

Dec 12, 2021

I think it would be more comprehensive if this option were called `mod storage` rather than `mod metadata` even if the current naming is technically correct.

Outdated

src/main.cpp

rubenwardy

Nov 17, 2021

Why is this a blob and not a VARCHAR or TEXT?

src/database/database-sqlite3.cpp

rubenwardy

Nov 17, 2021

Hmm, maybe we should define a max mod name so that this can use a VARCHAR. The longest mod name in ContentDB is `moremesecons_adjustable_player_detector` with 39 characters

src/database/database-sqlite3.cpp

rubenwardy

Nov 17, 2021

why "pairs"? "entry" would make more sense, it's more commonly used by key-value dictionaries - and doesn't imply there's only two columns

Outdated

src/database/database-sqlite3.cpp

appgurueu

Nov 9, 2021

Isn't this redundant due to the primary key constraint below?

src/database/database-sqlite3.cpp

appgurueu

Nov 7, 2021

Can't you drop the entire loop then?

Outdated

src/server.cpp

appgurueu

Nov 7, 2021

Shouldn't all of these work in-memory (currently they are no-op)?

Outdated

src/database/database-dummy.cpp