Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (5)
@sfan5 sfan5 Aug 7, 2022
general question (not for this PR): shouldn't this use a comparison with some margin of tolerance? or would that introduce a bug where it might miss collisions?
src/collision.cpp
appgurueu
@sfan5 sfan5 Aug 7, 2022
```suggestion float jump_height = (jumpspeed - 0.5f * gravity * peak_dtime) * peak_dtime; // s = vt - 1/2 gt^2 ```
Outdated
src/client/localplayer.cpp
@appgurueu appgurueu Jul 2, 2022
Should I perhaps not apply the fix to the `old_move` code?
Outdated
src/client/localplayer.cpp
sfan5
@lhofhansl lhofhansl May 25, 2022
So it's just replacing Euler with Runge-Kutta...? It's definitely going to be more accurate. We should make this change!
src/client/particles.cpp
@appgurueu appgurueu May 20, 2022
Could be optimized to `if (newpos_f == *pos_f)`
Outdated
src/collision.cpp