Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize builtin into subdirectories and use "core" namespace internally #1258

Merged
merged 2 commits into from May 10, 2014

Conversation

Projects
None yet
3 participants
@ShadowNinja
Copy link
Member

ShadowNinja commented Apr 27, 2014

minetest is still the official namespace for mods.

@sapier

This comment has been minimized.

Copy link
Contributor

sapier commented Apr 28, 2014

are you sure vector is "game" specific?

@ShadowNinja ShadowNinja changed the title Organize builtin into subdirectories Organize builtin into subdirectories and use "core" namespace Apr 29, 2014

@ShadowNinja

This comment has been minimized.

Copy link
Member Author

ShadowNinja commented Apr 29, 2014

@sapier: It currently is, however vectors themselves could conceivably be used by the mainmenu. I'll move it to common/.
EDIT: Done. I also seperated get_scriptdir into get_builtin_path and get_mainmenu_path and added a (minetest/engine)-->(core) commit.

@sapier

This comment has been minimized.

Copy link
Contributor

sapier commented Apr 29, 2014

I don't understand why you replace a generic name "engine" by another generic name "core", I see no benefit of adding two legacy support styles instead of having only one.

@ShadowNinja

This comment has been minimized.

Copy link
Member Author

ShadowNinja commented May 8, 2014

After discussion on IRC we've come to the conclusion that the core namespace should be used only internally for now.
I've updated the commit accordingly.

<celeron55> i asked freeminer's standing on the namespace issue from xyz, and it is this: 1) freeminer doesn't have plans to break api compatibility, 2) it already has an alias of the "minetest" namespace as "freeminer", 3) it will add an alias for "core" if minetest switches to it, 4) xyz seems to agree that if all forks have their own namespaces and everyone has to support everyone else's namespace, it's stupid
<celeron55> official decision:
<celeron55> minetest will use the minetest namespace for now and until more forks appear
<celeron55> however, if or when that happens, it will be changed
<celeron55> so if you make a fork, please use the "core" namespace because that's where everything will go then
<ShadowNinja> celeron55: So, should minetest use "core" only as a implementation detail?  Because using one name allows me to clean up part of the codebase.
<ShadowNinja> Otherwise Lua files use "local core = minetest or engine" and the like, and everything that creates a Lua stack has to create it's table seperately.
<celeron55> ShadowNinja: i'm not sure what makes most sense there... maybe switching it internally to core causes least conflicts in the future

@ShadowNinja ShadowNinja changed the title Organize builtin into subdirectories and use "core" namespace Organize builtin into subdirectories and use "core" namespace internally May 9, 2014

@ShadowNinja ShadowNinja merged commit c4359ff into minetest:master May 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ShadowNinja ShadowNinja deleted the ShadowNinja:builtin-organization branch May 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.