Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes in src/gettext.cpp #1327

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@JakubVanek
Copy link
Contributor

commented May 23, 2014

Hello minetest programmers,
I found a typo in file src/gettext.cpp while compiling on Windows XP with VS 2010 sp0.
Could you please accept my fix?
Thank you
EDIT: I also found "wild" bracket in wrong preprocessor block.

JakubVanek added some commits May 23, 2014

@JakubVanek JakubVanek changed the title fixed typo std::encl in src/gettext.cpp fixes in src/gettext.cpp May 23, 2014

@sapier

This comment has been minimized.

Copy link
Contributor

commented May 23, 2014

why do you expect the error message to be shown if language doesn't need to be changed?

@JakubVanek

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2014

I am from Czech Republic and I want to use Minetest with translations (I contributed to them), so in CMake I enabled Gettext. And during compilation in Visual Studio it gives me bunch of errors in this file before fix, after fix it normally compiles and Minetest works.

@sapier

This comment has been minimized.

Copy link
Contributor

commented May 24, 2014

JakubVanek I'm only talking about the bracket move the other fix is obviously right

@JakubVanek

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2014

Sorry, you're right. I will try to fix it now.

@sapier

This comment has been minimized.

Copy link
Contributor

commented May 24, 2014

ok no need for further work ... I already merged the upper commit .... next time plz use Capital letter at beginnig ;-)
merged 6922807

@sapier sapier closed this May 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.