Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu music (WIP) #1651

Closed
wants to merge 4 commits into from
Closed

Menu music (WIP) #1651

wants to merge 4 commits into from

Conversation

RealBadAngel
Copy link
Contributor

Added main menu music.
Allow subgames have own scores (kept in /menu folder).
Game starts with main score, subgame music is played when clicked subgame button.

TODO:

  • add volume settings, controls in main menu for them (perhaps separate audio tab?)
  • crossfading of tunes (if possible)

Any opinions? Suggestions?

@BlockMen
Copy link
Contributor

I'm still against any default music in main menu. But I'm fine with adding support for games.

@ghost
Copy link

ghost commented Sep 20, 2014

Id say to not provide any music for the engine main menu itself, but give games music, such as minetest_game and so on. If a game doesn't have any music, don't play anything.

Btw, how does one define their game music?

@MirceaKitsune
Copy link
Contributor

Do games specify the music themselves? If so I agree with this!

@p5yk0g3n3s1s
Copy link

👍 I agree with @paramat

@indriApollo
Copy link

Is this dead ?

@C1ffisme
Copy link

The issue might have stopped conversation, but it can be ressurected.

I agree with adding menu music (As well as music in the game too!).

@RealBadAngel
Copy link
Contributor Author

Why the fuck mt can be the only one game in the world without music at all?
Are all others devs deaf or something? :P

@RealBadAngel RealBadAngel added the Blocker The issue needs to be addressed before the next release. label Jul 11, 2015
@kilbith
Copy link
Contributor

kilbith commented Jul 11, 2015

Because tastes on music are extremely diverse and some might be dead irritating for the ears.

@nerzhul
Copy link
Member

nerzhul commented Jul 11, 2015

Sorry but i don't think the blocker tag is adapted here. Blocked is reversed to blocking bugs before releasing.

@nerzhul nerzhul added @ Client / Audiovisuals and removed Blocker The issue needs to be addressed before the next release. labels Jul 11, 2015
@paramat
Copy link
Contributor

paramat commented Jul 11, 2015

First we need something really short (less than 1 minute, players don't hang around in menus, and file sizes are big) that is composed exclusively for Minetest Game by someone who has played it or loves voxel games. Then whatever is chosen most won't like it, and it takes up a lot of memory, so it's difficult. I guess it's best being very short and fairly atmospheric / ambient / gentle. The MTGame team would decide on the music.

Not having music means players can supply their own favourite music, i'm usually listening to music when playing. Doing something only because others do it is no good reason, i find a game without music quite refreshing, if some are put off by this they are shallow, no loss to us.

We can't have a main score because the engine has no character, so only subgame music.

File size is a real problem though, MTGame is 2MB, a music file would be similar size or larger. With several subgames bundled most of the now huge Minetest download would be music files, i would rather use that data for other things. So if this ability is added it needs to be used carefully with very short pieces of music.

It may be a good idea to avoid all this by just not adding music at all, especially since menu music might be listened to once or twice, disliked by most, and then mostly muted or not listened to because players do not spend much time in menus. It doesn't seem to justify a huge amount of data.

@PilzAdam
Copy link
Contributor

@RealBadAngel because "Minetest" is a game engine, not a game.

@indriApollo
Copy link

So just play the score from selected subgame (the first one by default amirigth) and everyone's happy.
And if no subgame is installed, play for Beethoven's ears.

@paramat paramat added the Won't add The feature request was rejected and will not be added. label Jan 14, 2016
@paramat
Copy link
Contributor

paramat commented Jan 14, 2016

👎
Celeron55 is also strongly opposed to this.
Unless this PR is fundamentally changed it should be closed.
@RealBadAngel will close in 1 month if no response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Audiovisuals Won't add The feature request was rejected and will not be added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet