Fix FTBFS on GNU/Hurd platform #2162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minetest fails to build on GNU/Hurd due to a name clash with OSX/Apple, both are defining the __MACH__ keyword. This commit fixes the issue.
|
Can you remove minetest.desktop commit from this PR and do a separated commit please ? Idem with hyphen |
|
Hi, these are three separate commits but one pull request. You want me to make three PR, one for each commit? |
|
yes it's better for review and comments. 1 PR = 1 rebased commit and 1 modification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In Debian this patch was applied to achieve the following.
Minetest fails to build on GNU/Hurd due to a name clash with OSX/Apple, both are defining the MACH keyword. This commit fixes the issue.
One commit adds keywords to minetest.desktop. This might improve a desktop search in modern desktop environments such as GNOME3 or KDE. The other one fixes a minor issue in the minetest.6. An explanation can be found here:
https://lintian.debian.org/tags/hyphen-used-as-minus-sign.html
Thanks for considering the patch.