Fix FTBFS on GNU/Hurd platform #2164
Conversation
| @@ -360,6 +360,9 @@ inline u32 getDeltaMs(u32 old_time_ms, u32 new_time_ms) | |||
| } | |||
| #elif defined(_WIN32) | |||
| inline void setThreadName(const char* name) {} | |||
| #elif defined(__GNU__) | |||
| //#warning "GNU/Hurd platform, pthread_setname_np not yet supported" | |||
| inline void setThreadName(const char* name) {} | |||
There was a problem hiding this comment.
This does effectively the same thing as the default. Also, either the warning should be enabled or it should be a regular comment.
There was a problem hiding this comment.
I suggest to keep the conditional because GNU/Hurd is now a distinct and
known platform and it might be possible that the behaviour will be
different from the default in the future. The comment can be omitted.
There was a problem hiding this comment.
You can actually combine this with the Windows section too.
There was a problem hiding this comment.
GNU/Hurd is not Windows. A change in WIN32 or the default might have a
negative impact on GNU/Hurd again in the future. Hence I think it is
reasonable to make this distinction clear.
There was a problem hiding this comment.
Hurd doesn't support thread names though, same as Windows, so it's functionality is the same and it should be combined to reduce duplication. Hurd obviously isn't Windows, and I wasn't implying that. If Hurd or Windows get thread name support they can easily be given their own sections.
There was a problem hiding this comment.
Please tell me exactly how you want this to be fixed since I am not the
original patch creator. You can also fix this part in any way you see fit.
There was a problem hiding this comment.
you need to combine windows and hurd
ShadowNinja
added
@ Build
Minetest fails to build on GNU/Hurd due to a name clash with OSX/Apple, both are defining the __MACH__ keyword. This commit fixes the issue.
|
Pull request was updated. Please check again. |
|
Seems to be good. I agree for a merge |
|
commit cfca5f9 |
Here we go again.
Minetest fails to build on GNU/Hurd due to a name clash with OSX/Apple,
both are defining the MACH keyword. This commit fixes the issue.