Improve FindIrrlicht.cmake module #2371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux distributions prefer to link against a shared version of the Irrlicht engine instead of using embedded code copies of the same. Search for this shared version first and use that but fall back to the static version if it does not exist. This also fixes #2163
|
I think this could be good. Then i agree |
|
Merged, thanks (ok @ShadowNinja on IRC) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Linux distributions prefer to link against a shared version of the Irrlicht
engine instead of using embedded code copies. Search for this
shared version first and use that but fall back to the static version if it
does not exist.
This also fixes #2163