Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let travis check for git format mistakes #3142

Closed
wants to merge 8 commits into from

Conversation

Projects
None yet
4 participants
@est31
Copy link
Contributor

commented Sep 3, 2015

With this PR, travis checks now for multiple types of bad git formatting.

@est31

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2015

I've added some failing commits to show what travis will print, so it fails by purpose :D

@est31 est31 added the enhancement label Sep 3, 2015

@ShadowNinja

This comment has been minimized.

Copy link
Member

commented Sep 6, 2015

Should fail for the Windows builds too.

@est31 est31 force-pushed the est31:travis_git_guideline_checkk branch to fff35d5 Sep 6, 2015

@est31

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2015

@ShadowNinja done.

@@ -13,7 +13,7 @@ if [[ $PLATFORM == "Linux" ]]; then
cmake $CMAKE_FLAGS ..
make -j2
echo "Running unit tests."
../bin/minetest --run-unittests && exit 0
../bin/minetest --run-unittests || exit 1

This comment has been minimized.

Copy link
@sfan5

sfan5 Sep 7, 2015

Member

actually you can drop this because we call bash with the -e flag

elif [[ $PLATFORM == "Win64" ]]; then
$OLDDIR/util/buildbot/buildwin64.sh travisbuild && exit 0
$OLDDIR/util/buildbot/buildwin64.sh travisbuild || exit 1

This comment has been minimized.

Copy link
@sfan5

sfan5 Sep 7, 2015

Member

same with these

fi
else
echo "Unknown platform \"${PLATFORM}\"."
exit 1
fi

echo "Checking commits."
../util/check_git_guidelines.sh && exit 0

This comment has been minimized.

@sfan5 sfan5 added the @ Build label Sep 7, 2015

@paramat paramat referenced this pull request Mar 31, 2016

Closed

Add CONTRIBUTING(.md)? #2645

@paramat paramat removed the Enhancement label Oct 29, 2016

@sfan5 sfan5 force-pushed the minetest:master branch to 09f1a0c Dec 21, 2016

@est31 est31 closed this Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.