Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix world config menu ignoring `name` in `mod.conf`. #3433

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@kaeza
Copy link
Contributor

commented Dec 7, 2015

Also reorganize code to be cleaner.

See forum topic.

@kaeza

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2015

Possible conflict with #3392.

@kaeza

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2016

Do I need to remind devs that this is not exactly low priority?

@kilbith

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2016

^ @est31 @paramat

kaeza is highly trustable in Lua stuff.

@sofar

This comment has been minimized.

Copy link
Member

commented Jan 21, 2016

I pulled this branch and performed a rename test:

mv inspector ins.pe-cto_r

restarted minetest with this patch applied, and confirmed that the UI displayed the "inspector" mod. Enabled it, started a subgame, and typed /mods and confirmed that inspector was listed.

👍

@paramat

This comment has been minimized.

Copy link
Member

commented Jan 22, 2016

I'll +1 if another core dev checks the code.

@rubenwardy

This comment has been minimized.

Copy link
Member

commented Jan 23, 2016

Code looks okay to me. (To avoid miscommunication, I'm not a core dev)

@Dragonop

This comment has been minimized.

Copy link

commented Jan 24, 2016

Setting name = modname in mod.conf works for me, is this a bug that only happens "sometimes"?

@sofar

This comment has been minimized.

Copy link
Member

commented Jan 24, 2016

@Dragonop this happens when the folder name isn't modname but e.g. something like mod_na-me-v1231.zip##$$

@kaeza

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2016

@Dragonop In case it's not clear from the title, the issue this fixes is the world configuration dialog (Client Tab > Configure) does not respect the mod name.

A while ago, I coded a feature (#1062, of which only the one commit got in) which allows mods to specify the name of the mod in a mod.conf file, and makes the engine use that name for the mod regardless of the directory name.

Now, the engine (the server part, specifically) honors that configuration e.g. when the mod is put in a game's mods directory, or the world's worldmods directory, but I forgot to check the world configuration dialog, so if you put the mod in your user mods directory, you can't enable them at all unless you specifically rename the directory to match the actual mod name (which makes the new feature kinda useless).

This patch fixes that.

If you can, try using a non-patched client, and you will see sofar's example fail because it contains invalid characters. Now try a patched client, and you will see that you can now name the directory whatever you want and you can enable the mod correctly.

@ShadowNinja

This comment has been minimized.

Copy link
Member

commented Jan 24, 2016

@Dragonop

This comment has been minimized.

Copy link

commented Jan 24, 2016

I see it now, thanks @kaeza and @sofar.

@kaeza

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2016

@ShadowNinja, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.