Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V7 caves to Valleys mapgen. #3585

Closed
wants to merge 1 commit into from
Closed

Add V7 caves to Valleys mapgen. #3585

wants to merge 1 commit into from

Conversation

duane-r
Copy link
Contributor

@duane-r duane-r commented Jan 18, 2016

This adds a template for the CaveV7 class, so that Valleys mapgen can
use it without duplicating code.

This adds a template for the CaveV7 class, so that Valleys mapgen can
use it without duplicating code.
@paramat
Copy link
Contributor

paramat commented Jan 18, 2016

👎 An option to use mgv7 type large pseudorandom caves and 3D noise tunnels is okay by me, but instead use CaveV5 in cavegen.cpp for the large caves, it is identical to CaveV7 but it removes the unnecessary ridge heightmap, and CaveV5 has already been changed to be usable with any mapgen, see how mgflat and mgfractal use it.

You can still refer to the option as 'mgv7 caves' to avoid confusion, and because the 3D noise tunnels are still from mgv7, just at the end of 'generateV7Caves()' call CaveV5 instead.

This way you won't need to change CaveV7 in cavegen.cpp at all.

@duane-r
Copy link
Contributor Author

duane-r commented Jan 18, 2016

instead use CaveV5 in cavegen.cpp

Cool. I will rework that. I think I'll change the flags to V5 though, just to avoid confusing me.

@duane-r duane-r closed this Jan 18, 2016
@duane-r duane-r deleted the v7caves branch January 19, 2016 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants