Restore simple settings tab and add advanced settings as dialog

[kilbith]

Rebased version of #3514. Fixes #3486 (blocker).

It has 2 approvals on the original PR and just stands there to be merged.

Credit is of course given to @BlockMen.

Cc: @paramat

[paramat]

Thanks for doing this. I'll review and test as soon as i can.

[paramat]

Some minor code style issues.

[kilbith]

Fixed'em all.

[PilzAdam]

Which window is displayed after clicking "Save" in the change settings dialog? The advanced menu again or the simple settings tab? (sorry, I currently can't test this myself)

[kilbith]

@PilzAdam As currently : the advanced menu.

[PilzAdam]

@kilbith that's good. 👍

[paramat]

Tested and seems to work.
One strange thing is when shaders are disabled and i toggle a graphics setting like 'smooth lighting', the shaders bars go green:

+1 once that's fixed.

[kilbith]

@paramat This glitch has always existed but fixed now.

By the way, I trashed the code of the viewing range scrollbars that I added in the past. BlockMen removed these scrollbars already but not some remaining code. Anyways it was destined to be obsolete as you (core-devs) intend to trash the auto viewing range very soon.

[paramat]

That all sounds good 👍

[Fixer-007]

I think this also needs to have at least two additions:

• "Tone mapping" above bumpmapping
• "View range" slider below "Antialiasing" (there is PR that will discard autorange here Camera: remove auto tune FPS, single view range setting #3749)

[paramat]

Tone mapping, maybe, but could be added later.
View range slider, no, that's easily adjusted in-game (the only place you know what range is optimum) and sliders are imprecise.

[paramat]

This PR should go in fast because it's delaying other stuff, so above issues can be another commit.

[paramat]

👍 Tested, i will merge soon.

[paramat]

ecc8b70